docker cleanup #90
Merged
docker cleanup #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: repository currently contains two seperate docker definitions that are confusing to users Modifications: * remove Dockerfile.xenial so we have a canonical docker file for CI and developer testing * point docker compose to canonical docker file * define docker compose services for unit and integration tests. and make "test" service run both * update readme Result: users are less confused about docker setup
|
Why do we need to remove |
|
@Lukasa to make docker compose based testing identical to our CI. there is an argument to be made to add tests for both versions, but until we do i prefer to avoid the confusion this can (and did) cause , and allow running integration tests via docker compose which was not possible in the existing version |
|
yup, that’s what we use in CI |
normanmaurer
approved these changes
Mar 4, 2018
|
@tomerd please rebase and merge. |
weissi
pushed a commit
to weissi/swift-nio
that referenced
this pull request
Jun 13, 2020
Motivation: RFC 7540 requires that HTTP/2 pseudo-headers must be first in a HTTP/2 header block, and must occur before any regular headers. We should enforce that requirement. Modifications: - Added checking that pseudo-headers are first in a header block. Result: Better RFC 7540 validation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
repository currently contains two seperate docker definitions that are confusing to users
Modifications:
Result:
users are less confused about docker setup