Skip to content

Add remove(where:) to RangeReplaceableCollection #11576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2018
Merged

Add remove(where:) to RangeReplaceableCollection #11576

merged 1 commit into from
Apr 7, 2018

Conversation

airspeedswift
Copy link
Member

Initial implementation for swiftlang/swift-evolution#675

@airspeedswift
Copy link
Member Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - f3e48e4e72b64b41a89b9029abbc279a20aa39af

@airspeedswift
Copy link
Member Author

@swift-ci please test linux platform

dabrahams
dabrahams reviewed Nov 15, 2017
View reviewed changes
stdlib/public/core/RangeReplaceableCollection.swift.gyb Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This summary seems to be wrong..

Given that the names in the proposal have been changed, and the intent behind having an implementation is that people can get actual experience with the proposal, I think this PR should be updated before we run the review.

dabrahams
dabrahams reviewed Nov 15, 2017
View reviewed changes
stdlib/public/core/RangeReplaceableCollection.swift.gyb Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This parameter doesn't seem to exist

dabrahams
dabrahams reviewed Nov 15, 2017
View reviewed changes
stdlib/public/core/RangeReplaceableCollection.swift.gyb Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to make that fix separately from this PR

dabrahams
dabrahams reviewed Nov 15, 2017
View reviewed changes
stdlib/public/core/RangeReplaceableCollection.swift.gyb Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter name is predicate, not where, thank goodness!

dabrahams
dabrahams reviewed Nov 15, 2017
View reviewed changes
test/stdlib/RemoveElements.swift Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy/paste error?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

derp... thx

@airspeedswift airspeedswift changed the title Add removeAll(where:) to RangeReplaceableCollection Add remove(where:) to RangeReplaceableCollection Nov 16, 2017
@airspeedswift
Copy link
Member Author

@swift-ci please test

@martinr448
Copy link

I am not sure if it matters, but in remove(where:) the predicate is always evaluated twice for the first matching element, because the starting value for j is i, not its successor.

@airspeedswift
Copy link
Member Author

@martinr448 yeah, it also shouldn't use indices. I have been tinkering with this for a few different reasons including what the state should be if the predicate throws halfway, will push a new version soon.

@airspeedswift
Copy link
Member Author

@swift-ci please test and merge

@swift-ci swift-ci merged commit 3430f38 into swiftlang:master Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dabrahams dabrahams dabrahams left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@airspeedswift @swift-ci @martinr448 @dabrahams