Rename @effects to @_effects #17023
Merged
Rename @effects to @_effects #17023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@effects is too low a level, and not meant for general usage outside the standard library. Therefore it deserves to be underscored like other such attributes.
|
@jckarter I've been told this change doesn't need to go through SE. |
|
LGTM, thanks! |
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
jckarter
approved these changes
Jun 6, 2018
|
@jckarter Looks like CoreStore is failing for tvOS and watchOS, this happens with the 4.2 compiler in the beta, so it doesn't look like my changes. Probably need to file an issue with that project to have them update something? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@effectsis too low a level, and not meant for general usage outsidethe standard library. Therefore it deserves to be underscored like
other such attributes.