[DNM] SIMD, take 2 #20344

stephentyrone · 2018-11-06T03:55:31Z

Updated SIMD implementation, based on feedback from first round of review.

This approach, suggested by Chris, is probably more flexible in the long run, but in the short-term we'll have some fairly ugly codegen with -Onone (-O builds are mostly OK except where masks come into it). We'll need some @_semantics wizardry to make this really work, but it definitely lets us have significantly less boilerplate going forward.

Under discussion as SE-0229

rudkx · 2018-11-08T01:02:33Z

Can you make sure to test the validation tests of a release no-assertions build to ensure they pass after the new overloads are added?

Specifically the tests in validation-test/Sema/type_checker_perf?

Some of those run on one of the builders but do not get tested by the normal PR testing (other tests, the ones based on scale-test, do run in the PR testing).

stephentyrone · 2018-11-08T13:50:08Z

@rudkx Yup. There's a little bit of additional cleanup to do and I want to rebase on @rxwei's AdditiveArithmetic changes, since those also tie into this, and then I'll start in on that.

stephentyrone · 2018-11-12T17:26:08Z

@swift-ci please test

swift-ci · 2018-11-12T17:26:37Z

Build failed
Swift Test OS X Platform
Git Sha - b72195a09296816363e059bbebc80b16dcf1f34c

swift-ci · 2018-11-12T18:23:14Z

Build failed
Swift Test Linux Platform
Git Sha - fe5af74cf40cbe5c611f2a74e6ef53b8bca04b38

lattner · 2018-11-14T05:08:02Z

@rxwei FYI, this is the updated patch with some renamings to consider if you are interested.

rxwei · 2018-11-14T06:06:32Z

The proposal hasn't been updated to reflect the implementation. I have comments (many, i think) but I'd like to quote contents of the proposal instead of the PR.

Also changes elementCount to scalarCount, per review thread.

Move all SIMD-associated things under SIMD names, both for clarity and so we can use the name Vector for math vectors at some future point if we want. - Vectorizable -> SIMDScalar - SIMDVector -> SIMD - SIMDMaskVector -> SIMDMask - VectorStorage -> SIMDStorage - Vector${N} -> SIMD${N} This also removes the SIMDMask protocol entirely, leaving only the concrete type, by reworking how the mask associated type works.

stephentyrone · 2018-11-16T17:46:23Z

@swift-ci Please test

swift-ci · 2018-11-16T17:46:53Z

Build failed
Swift Test OS X Platform
Git Sha - fe5af74cf40cbe5c611f2a74e6ef53b8bca04b38

swift-ci · 2018-11-16T17:48:15Z

Build failed
Swift Test Linux Platform
Git Sha - fe5af74cf40cbe5c611f2a74e6ef53b8bca04b38

Also updates GenClangType.cpp to be able to map from SIMD types to ExtVectors (the reverse mapping and importer support are not done yet, and will be in a follow-on patch), and updates tests to account for the new spellings.

stephentyrone · 2018-11-16T19:41:17Z

@swift-ci Please test

stephentyrone · 2018-11-16T19:41:29Z

@swift-ci please test source compatibility

swift-ci · 2018-11-16T19:43:16Z

Build failed
Swift Test Linux Platform
Git Sha - 8b10812

swift-ci · 2018-11-16T19:44:07Z

Build failed
Swift Test OS X Platform
Git Sha - 8b10812

stephentyrone · 2018-11-16T21:07:00Z

@swift-ci Please test

swift-ci · 2018-11-16T21:07:37Z

Build failed
Swift Test OS X Platform
Git Sha - 83642ae

swift-ci · 2018-11-16T21:09:23Z

Build failed
Swift Test Linux Platform
Git Sha - 83642ae

stephentyrone · 2018-11-17T01:34:55Z

@swift-ci please test

swift-ci · 2018-11-17T01:36:54Z

Build failed
Swift Test Linux Platform
Git Sha - 539d6b2

swift-ci · 2018-11-17T01:40:01Z

Build failed
Swift Test OS X Platform
Git Sha - 539d6b2

stephentyrone · 2018-11-17T17:34:28Z

@swift-ci please test

stephentyrone · 2018-11-17T17:34:38Z

@swift-ci please test source compatibility

swift-ci · 2018-11-17T17:36:28Z

Build failed
Swift Test Linux Platform
Git Sha - 64474a2

swift-ci · 2018-11-17T17:36:32Z

Build failed
Swift Test OS X Platform
Git Sha - 64474a2

stephentyrone · 2018-11-17T21:25:32Z

@swift-ci please test

swift-ci · 2018-11-17T21:27:31Z

Build failed
Swift Test Linux Platform
Git Sha - 9eea4c4

swift-ci · 2018-11-17T23:41:16Z

Build failed
Swift Test OS X Platform
Git Sha - 6c69d94

stephentyrone · 2018-11-29T16:10:52Z

@swift-ci please test OS X

gottesmm · 2018-11-29T23:20:53Z

@stephentyrone woot!

xedin · 2018-11-30T05:51:39Z

I think this should have been reviewed by either me or @rudkx, it looks like after these changes multiple previously resolved crashers are now crashing again (which is very concerning), and performance of expressions with multiple iterators have degraded...

stephentyrone force-pushed the simd-2 branch from f0ab959 to 852303e Compare November 12, 2018 14:14

stephentyrone added 14 commits November 16, 2018 09:59

new simd types, take 2, generic boogaloo.

dc03599

More stuff, support for vectors up to 64.

b1393c4

Formatting, add random( ), elements and halves.

5c6a1b6

Mark stuff public that should be public.

58da925

More floating point functionality.

ee9d5dd

Some more conversions.

24677ad

typos.

acceb5d

Re-instate init from array literal and sequence.

f303a07

Rename _-prefixed simd protocol requirements

81e8d8a

Also changes elementCount to scalarCount, per review thread.

Reinstate prefix- for floatingpoint vectors.

8dd9d1c

Update cake.json to account for SIMDScalar conformance.

a8032ab

Update cake-abi.json too.

47797bf

Disable one complex_expressions test for now.

8b10812

stephentyrone force-pushed the simd-2 branch from fe5af74 to 8b10812 Compare November 16, 2018 17:45

Changes to SDK overlays to account for new SIMD types.

83642ae

Also updates GenClangType.cpp to be able to map from SIMD types to ExtVectors (the reverse mapping and importer support are not done yet, and will be in a follow-on patch), and updates tests to account for the new spellings.

Restore vector alignment requirements.

539d6b2

stephentyrone added 2 commits November 16, 2018 19:20

Fixes for inherits_NSObject.swift validation test

5142b74

Move two crashers back to not-fixed.

64474a2

One more validation test fix.

9eea4c4

additional fixes to inherits_ObjCClasses.swift

6c69d94

stephentyrone merged commit fb8b9e1 into swiftlang:master Nov 29, 2018

stephentyrone deleted the simd-2 branch February 8, 2023 00:36

[DNM] SIMD, take 2 #20344

[DNM] SIMD, take 2 #20344

Uh oh!

Conversation

stephentyrone commented Nov 6, 2018

Uh oh!

rudkx commented Nov 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stephentyrone commented Nov 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stephentyrone commented Nov 12, 2018

Uh oh!

swift-ci commented Nov 12, 2018

Uh oh!

swift-ci commented Nov 12, 2018

Uh oh!

lattner commented Nov 14, 2018

Uh oh!

rxwei commented Nov 14, 2018

Uh oh!

stephentyrone commented Nov 16, 2018

Uh oh!

swift-ci commented Nov 16, 2018

Uh oh!

swift-ci commented Nov 16, 2018

Uh oh!

stephentyrone commented Nov 16, 2018

Uh oh!

stephentyrone commented Nov 16, 2018

Uh oh!

swift-ci commented Nov 16, 2018

Uh oh!

swift-ci commented Nov 16, 2018

Uh oh!

stephentyrone commented Nov 16, 2018

Uh oh!

swift-ci commented Nov 16, 2018

Uh oh!

swift-ci commented Nov 16, 2018

Uh oh!

stephentyrone commented Nov 17, 2018

Uh oh!

swift-ci commented Nov 17, 2018

Uh oh!

swift-ci commented Nov 17, 2018

Uh oh!

stephentyrone commented Nov 17, 2018

Uh oh!

stephentyrone commented Nov 17, 2018

Uh oh!

swift-ci commented Nov 17, 2018

Uh oh!

swift-ci commented Nov 17, 2018

Uh oh!

stephentyrone commented Nov 17, 2018

Uh oh!

swift-ci commented Nov 17, 2018

Uh oh!

swift-ci commented Nov 17, 2018

Uh oh!

stephentyrone commented Nov 29, 2018

Uh oh!

gottesmm commented Nov 29, 2018

Uh oh!

xedin commented Nov 30, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

rudkx commented Nov 8, 2018 •

edited

Loading

stephentyrone commented Nov 8, 2018 •

edited

Loading