[SE-0248] String Gaps #22869

milseman · 2019-02-25T00:12:37Z

8 simple APIs on Unicode’s various encodings
2 generic initializers for string indices and ranges of indices
Substring.base, equivalent to Slice.base
Make Character.UTF8View and Character.UTF16View public
Add Unicode.Scalar.UTF8View

milseman · 2019-02-25T00:12:47Z

@swift-ci please benchmark

swift-ci · 2019-02-25T01:03:44Z

Performance: -O

TEST	OLD	NEW	DELTA	RATIO
Regression
FlattenListLoop	3561	3888	+9.2%	0.92x
Array2D	6208	6736	+8.5%	0.92x (?)
LessSubstringSubstring	36	39	+8.3%	0.92x (?)
EqualStringSubstring	36	39	+8.3%	0.92x (?)
EqualSubstringSubstringGenericEquatable	36	39	+8.3%	0.92x (?)
EqualSubstringString	36	39	+8.3%	0.92x (?)
LessSubstringSubstringGenericComparable	36	39	+8.3%	0.92x (?)
MapReduce	330	356	+7.9%	0.93x (?)
MapReduceAnyCollection	331	357	+7.9%	0.93x (?)
StringToDataEmpty	650	700	+7.7%	0.93x (?)

Performance: -Osize

TEST	OLD	NEW	DELTA	RATIO
Regression
CharacterLiteralsLarge	89	100	+12.4%	0.89x
Set.isDisjoint.Box.Empty	170	187	+10.0%	0.91x (?)
Set.isSubset.Empty.Int	148	162	+9.5%	0.91x (?)
RemoveWhereFilterInts	38	41	+7.9%	0.93x (?)

Performance: -Onone

TEST	OLD	NEW	DELTA	RATIO
Improvement
StringBuilderWithLongSubstring	3140	2690	-14.3%	1.17x (?)
StringEdits	190500	169700	-10.9%	1.12x (?)
StrComplexWalk	6570	5920	-9.9%	1.11x
WordCountUniqueUTF16	11940	11110	-7.0%	1.07x (?)
WordCountUniqueASCII	11560	10770	-6.8%	1.07x (?)

How to read the data

The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview

  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 8-Core Intel Xeon E5
  Processor Speed: 3 GHz
  Number of Processors: 1
  Total Number of Cores: 8
  L2 Cache (per Core): 256 KB
  L3 Cache: 25 MB
  Memory: 64 GB

milseman · 2019-02-27T19:47:29Z

@swift-ci please test

swift-ci · 2019-02-27T20:53:31Z

Build failed
Swift Test Linux Platform
Git Sha - c18703d97609368c5da1b84cecd9e0e5a91f51a5

swift-ci · 2019-02-27T21:29:06Z

Build failed
Swift Test OS X Platform
Git Sha - c18703d97609368c5da1b84cecd9e0e5a91f51a5

milseman · 2019-02-28T02:05:27Z

@swift-ci please test

swift-ci · 2019-02-28T02:07:31Z

Build failed
Swift Test Linux Platform
Git Sha - c18703d97609368c5da1b84cecd9e0e5a91f51a5

swift-ci · 2019-02-28T02:56:34Z

Build failed
Swift Test OS X Platform
Git Sha - c18703d97609368c5da1b84cecd9e0e5a91f51a5

milseman · 2019-02-28T18:07:55Z

What?

/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/llvm/tools/clang/lib/DirectoryWatcher/DirectoryWatcher-linux.inc.h:95:23: error: use of undeclared identifier 'RetryAfterSignal'

tkremenek · 2019-03-22T14:34:53Z

The evolution proposal for this change has been accepted.

tkremenek · 2019-03-22T14:35:02Z

@swift-ci clean test

swift-ci · 2019-03-22T15:43:23Z

Build failed
Swift Test Linux Platform
Git Sha - 3b4fce9d346cd75631418a6653ef80c5a3020b8c

tkremenek · 2019-03-26T00:34:38Z

@swift-ci clean test

swift-ci · 2019-03-26T01:51:14Z

Build failed
Swift Test Linux Platform
Git Sha - 3b4fce9d346cd75631418a6653ef80c5a3020b8c

swift-ci · 2019-03-26T02:09:03Z

Build failed
Swift Test OS X Platform
Git Sha - 3b4fce9d346cd75631418a6653ef80c5a3020b8c

milseman · 2019-03-28T23:21:25Z

@swift-ci please test

swift-ci · 2019-03-29T00:17:05Z

Build failed
Swift Test Linux Platform
Git Sha - 3b4fce9d346cd75631418a6653ef80c5a3020b8c

airspeedswift · 2019-03-29T22:29:42Z

/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/swift/test/stdlib/StringIndex.swift:205:8: error: no such module 'Foundation'

😕

milseman · 2019-03-29T22:41:57Z

Ah, so it seems we need to guard any of that functionality

This adds new (availability-controlled) API to Unicode.Scalar, exposing the scalar's UTF-8 code units as a random-access collection similarly to how it currently exposes UTF-16 code units. Tests added.

Add convenience APIs to the stdlib's Unicode encodings: * Unicode.UTF16 * isASCII * isSurrogate * Unicode.UTF8 * isASCII * width * Unicode.UTF32 * isASCII * Unicode.ASCII * isASCII Tests added

Adds a generic version of String.Index.init?(_:within:) and Range<String.Index>.init?(_:in:). Tests added

Adds these collections, which are just String's views. Tests added.

Adds Substring.base, analogous to Slice.base, to access the entire String. Tests added.

Bounds check the given index for String.Index's generic initializer that makes sure a passed index is a valid one for the given StringProtocol.

milseman · 2019-04-01T16:33:56Z

@swift-ci please test

swift-ci · 2019-04-01T16:36:33Z

Build failed
Swift Test Linux Platform
Git Sha - 3b4fce9d346cd75631418a6653ef80c5a3020b8c

swift-ci · 2019-04-01T16:38:17Z

Build failed
Swift Test OS X Platform
Git Sha - 3b4fce9d346cd75631418a6653ef80c5a3020b8c

milseman · 2019-04-01T20:52:28Z

@swift-ci please test OS X platform

swift-ci · 2019-04-01T21:45:20Z

Build failed
Swift Test OS X Platform
Git Sha - c36daeb

milseman · 2019-04-02T00:55:35Z

Jenkins crashed.

@swift-ci please test OS X platform

milseman force-pushed the gab_barg branch 2 times, most recently from f25110b to c18703d Compare February 27, 2019 19:33

milseman force-pushed the gab_barg branch from c18703d to 8f44eb9 Compare February 27, 2019 23:11

milseman changed the title ~~[WIP DO NOT MERGE]: String Grab Bag~~ [WIP Awaiting Review]: String Grab Bag Feb 28, 2019

milseman force-pushed the gab_barg branch 2 times, most recently from a0f6a31 to 3b4fce9 Compare March 5, 2019 00:42

tkremenek added the swift evolution approved Flag → feature: A feature that was approved through the Swift evolution process label Mar 22, 2019

milseman added 4 commits March 29, 2019 15:43

[Unicode.Scalar] Add RAC UTF8View

751cf26

This adds new (availability-controlled) API to Unicode.Scalar, exposing the scalar's UTF-8 code units as a random-access collection similarly to how it currently exposes UTF-16 code units. Tests added.

[stdlib] Add LegacyABI.swift for legacy non-API declarations

b6a158e

[Unicode] Add convenience APIs to Unicode encodings

4967fc0

Add convenience APIs to the stdlib's Unicode encodings: * Unicode.UTF16 * isASCII * isSurrogate * Unicode.UTF8 * isASCII * width * Unicode.UTF32 * isASCII * Unicode.ASCII * isASCII Tests added

[String] Add generic String.Index and range inits within a String

b19c2cf

Adds a generic version of String.Index.init?(_:within:) and Range<String.Index>.init?(_:in:). Tests added

milseman added 4 commits March 29, 2019 15:43

[String] Add Character.UTF16View and Character.UTF8View

aa51936

Adds these collections, which are just String's views. Tests added.

[String] Add Substring.base

0ece62d

Adds Substring.base, analogous to Slice.base, to access the entire String. Tests added.

[String] String.Index.init(_:within:) bounds checks

3923fb2

Bounds check the given index for String.Index's generic initializer that makes sure a passed index is a valid one for the given StringProtocol.

[tests] Adjust tests for Linux

c36daeb

milseman force-pushed the gab_barg branch from 3b4fce9 to c36daeb Compare April 1, 2019 16:32

milseman changed the title ~~[WIP Awaiting Review]: String Grab Bag~~ String Grab Bag Apr 1, 2019

milseman mentioned this pull request Apr 1, 2019

[5.1][SE-0248] String Gaps #23706

Merged

milseman changed the title ~~String Grab Bag~~ [SE-0248] String Gaps Apr 1, 2019

milseman merged commit ff39c34 into swiftlang:master Apr 2, 2019

milseman mannequin mentioned this pull request Feb 27, 2019

[SR-9955] String.Index.init?<S: StringProtocol>(_ sourcePosition: Swift.String.Index, within target: S) is missing #52358

Closed

AnthonyLatsis added swift evolution implemented Flag → feature: A feature that was approved through the Swift evolution process and implemented and removed swift evolution approved Flag → feature: A feature that was approved through the Swift evolution process labels Feb 24, 2023

[SE-0248] String Gaps #22869

[SE-0248] String Gaps #22869

Uh oh!

Conversation

milseman commented Feb 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

milseman commented Feb 25, 2019

Uh oh!

swift-ci commented Feb 25, 2019

Performance: -O

Performance: -Osize

Performance: -Onone

Uh oh!

milseman commented Feb 27, 2019

Uh oh!

swift-ci commented Feb 27, 2019

Uh oh!

swift-ci commented Feb 27, 2019

Uh oh!

milseman commented Feb 28, 2019

Uh oh!

swift-ci commented Feb 28, 2019

Uh oh!

swift-ci commented Feb 28, 2019

Uh oh!

milseman commented Feb 28, 2019

Uh oh!

tkremenek commented Mar 22, 2019

Uh oh!

tkremenek commented Mar 22, 2019

Uh oh!

swift-ci commented Mar 22, 2019

Uh oh!

tkremenek commented Mar 26, 2019

Uh oh!

swift-ci commented Mar 26, 2019

Uh oh!

swift-ci commented Mar 26, 2019

Uh oh!

milseman commented Mar 28, 2019

Uh oh!

swift-ci commented Mar 29, 2019

Uh oh!

airspeedswift commented Mar 29, 2019

Uh oh!

milseman commented Mar 29, 2019

Uh oh!

milseman commented Apr 1, 2019

Uh oh!

swift-ci commented Apr 1, 2019

Uh oh!

swift-ci commented Apr 1, 2019

Uh oh!

milseman commented Apr 1, 2019

Uh oh!

swift-ci commented Apr 1, 2019

Uh oh!

milseman commented Apr 2, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

milseman commented Feb 25, 2019 •

edited

Loading