[stdlib] Add ContiguousCollection #23616
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| //===----------------------------------------------------------------------===// | ||
|
|
||
| /// A collection that supports access to its underlying contiguous storage. | ||
| @available(iOS 9999, OSX 9999, tvOS 9999, watchOS 9999, *) |
There was a problem hiding this comment.
Suggested change
| @available(iOS 9999, OSX 9999, tvOS 9999, watchOS 9999, *) | |
| @available(macOS 9999, iOS 9999, tvOS 9999, watchOS 9999, *) |
OSX => macOS (11 times) and in same order as rest of stdlib, for easier find and replace.
| @available(iOS 9999, OSX 9999, tvOS 9999, watchOS 9999, *) | ||
| public protocol ContiguousCollection: Collection | ||
| where SubSequence: ContiguousCollection { | ||
| /// Calls a closure with a pointer to the array's contiguous storage. |
There was a problem hiding this comment.
Suggested change
| /// Calls a closure with a pointer to the array's contiguous storage. | |
| /// Calls a closure with a pointer to contiguous storage. |
Remove: the array's (also in the proposal).
| @available(iOS 9999, OSX 9999, tvOS 9999, watchOS 9999, *) | ||
| public protocol MutableContiguousCollection: ContiguousCollection, MutableCollection | ||
| where SubSequence: MutableContiguousCollection { | ||
| /// Calls the given closure with a pointer to the array's mutable contiguous |
There was a problem hiding this comment.
Suggested change
| /// Calls the given closure with a pointer to the array's mutable contiguous | |
| /// Calls the given closure with a pointer to mutable contiguous |
Remove: the array's (also in the proposal).
| /// A collection that supports mutable access to its underlying contiguous | ||
| /// storage. | ||
| @available(iOS 9999, OSX 9999, tvOS 9999, watchOS 9999, *) | ||
| public protocol MutableContiguousCollection: ContiguousCollection, MutableCollection |
There was a problem hiding this comment.
Wrap to 80 characters?
| extension Slice: ContiguousCollection where Base: ContiguousCollection { } | ||
|
|
||
| @available(iOS 9999, OSX 9999, tvOS 9999, watchOS 9999, *) | ||
| extension Slice: MutableContiguousCollection where Base: MutableContiguousCollection { } |
There was a problem hiding this comment.
Wrap to 80 characters?
|
SE-0256 has been rejected during formal Swift Evolution review. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for swiftlang/swift-evolution#990
Tests tk