[Concurrency] Improve data-race detection for locals and globals #35203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve data-race detection for local variables and global/static variables * Only diagnose these cases at all, not (e.g.) class instance members * For local functions, they run concurrently if they were referenced somewhere that runs concurrently The latter required moving checking of both actor isolation and effects for local functions to the point at which their enclosing (non-local) functions are checked, because we need to reason about the type-checked bodies of local functions.
ktoso
reviewed
Dec 23, 2020
|
|
||
| func submitNext() async throws { | ||
| await group.add { | ||
| await group.add { [submitted,i] in |
There was a problem hiding this comment.
nice that this is caught now!
Nitpitck:
Suggested change
| await group.add { [submitted,i] in | |
| await group.add { [submitted, i] in |
There was a problem hiding this comment.
Alright, will clean up locally.
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
|
@swift-ci please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve data-race detection for local variables and global/static variables
that runs concurrently
The latter required moving checking of both actor isolation and effects
for local functions to the point at which their enclosing (non-local)
functions are checked, because we need to reason about the
type-checked bodies of local functions.