Fix SR-15785 by adding a cached reference to the last linked list node, avoiding n^2 append scaling #41165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e, avoiding n^2 append scaling
|
@swift-ci please test and merge |
|
it would be nice, if we could also add a benchmark to ensure that we do not regress in future |
|
Yes, I'm working on that currently. Using Concurrency stuff in the benchmarks is slightly non-obvious for now. |
|
Turns out "slightly non-obvious" is actually more like extremely non-obvious, adding a regression test will have to wait a bit, sorry. |
rjmccall
reviewed
Feb 3, 2022
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speeds up a trivial benchmark with 50,000 appends from 10+ seconds in a release build, to 0.2 seconds in a debug build, on my machine.
Fixes rdar://88219931