[NFC] Modify AccessScope to allow checks for package access level #62704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
tshortli
reviewed
Jan 6, 2023
artemcm
approved these changes
Jan 9, 2023
nkcsgexi
approved these changes
Jan 9, 2023
|
@swift-ci test |
|
@elsh could you please squash the commits? |
I usually do it at the time of merge. Is it to make reviews easier or does each commit still show up separately in git log otherwise? |
|
@swift-ci test |
tshortli
approved these changes
Jan 13, 2023
beccadax
requested changes
Jan 13, 2023
Resolves rdar://103534243
|
@swift-ci test |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add checks to distinguish between public and package access level.
Add enum AccessLimitKind to be used by AccessScope::Value
Resolves rdar://103534243