CMake: run `generate_xcode.test` only for the host platform #71279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

edymtt merged 1 commit into swiftlang:main from edymtt:edymtt/run-generate-xcode-only-for-host-architecture

Feb 6, 2024

Contributor

edymtt commented Jan 31, 2024 •

edited

Loading

Currently the test assumes that when we are testing for macOS we are targeting the host architecture (since we need to reuse existing build products to contain the test time) -- however there are some Apple internal configurations in which that's not the case.

Addresses rdar://118337598


          CMake: run generate_xcode.txt only for the host platform

df1619b

Currently the test assumes that when we are testing for macOS we are
targeting the host architecture (since we need to reuse existing build
products to contain the test time) -- however there are some Apple
internal configuration in which that's not the case.

Addresses rdar://118337598

edymtt requested review from AnthonyLatsis, ahoppen, rintaro and shahmishal

January 31, 2024 17:24

Contributor Author

edymtt commented Jan 31, 2024

@swift-ci please test

Contributor Author

edymtt commented Jan 31, 2024

@swift-ci Please Build Toolchain

Contributor Author

edymtt commented Jan 31, 2024

@swift-ci Please test stdlib with toolchain

Contributor Author

edymtt commented Jan 31, 2024

@swift-ci please test Apple Silicon

AnthonyLatsis approved these changes

View reviewed changes

Collaborator

AnthonyLatsis left a comment

Thank you!

Contributor Author

edymtt commented Jan 31, 2024

@swift-ci please test Apple Silicon

Contributor Author

edymtt commented Jan 31, 2024

Recording CI run for stdlib with toolchain
before kicking the test for the minimal freestanding stdlib

Contributor Author

edymtt commented Jan 31, 2024

preset=stdlib_S_standalone_minimal_macho_x86_64,build,test
@swift-ci please test with toolchain and preset

1 similar comment

Contributor Author

edymtt commented Jan 31, 2024

preset=stdlib_S_standalone_minimal_macho_x86_64,build,test
@swift-ci please test with toolchain and preset

edymtt changed the title ~~CMake: run generate_xcode.txt only for the host platform~~ CMake: run generate_xcode.test only for the host platform

Contributor Author

edymtt commented Jan 31, 2024

preset=stdlib_S_standalone_minimal_macho_x86_64,build,test
@swift-ci please test with toolchain and preset

3 similar comments

Contributor Author

edymtt commented Jan 31, 2024

preset=stdlib_S_standalone_minimal_macho_x86_64,build,test
@swift-ci please test with toolchain and preset

Contributor Author

edymtt commented Jan 31, 2024

preset=stdlib_S_standalone_minimal_macho_x86_64,build,test
@swift-ci please test with toolchain and preset

Contributor Author

edymtt commented Feb 1, 2024

preset=stdlib_S_standalone_minimal_macho_x86_64,build,test
@swift-ci please test with toolchain and preset

Contributor Author

edymtt commented Feb 1, 2024

@swift-ci please test Apple Silicon

Contributor Author

edymtt commented Feb 1, 2024

preset=stdlib_S_standalone_minimal_macho_x86_64,build,test
@swift-ci please test with toolchain and preset

1 similar comment

Contributor Author

edymtt commented Feb 1, 2024

preset=stdlib_S_standalone_minimal_macho_x86_64,build,test
@swift-ci please test with toolchain and preset

Contributor Author

edymtt commented Feb 1, 2024

Getting the same failures as the incremental job for the minimal stdlib PR job.

Contributor Author

edymtt commented Feb 2, 2024

@swift-ci please test Apple Silicon

Contributor Author

edymtt commented Feb 2, 2024

Verified that BuildSystem/generate_xcode.test is still executed in the macOS and ASi bots (the two tests in the latter are unrelated to this change).

edymtt merged commit 2072bf8 into swiftlang:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet