Skip to content

Conversation

@kateinoigakukun
Copy link
Member

This change allows the Wasm stdlib to be built using the prebuilt Swift toolchain instead of just built from source without building compiler tools. For example, I'm using the following build preset on my local.

skip-build-llvm
skip-build-swift
skip-build-cmark
skip-build-benchmarks
skip-early-swift-driver

build-wasm-stdlib

native-swift-tools-path=/path/to/swift-source/install/usr/bin
native-clang-tools-path=/path/to/swift-source/install/usr/bin
native-llvm-tools-path=/path/to/swift-source/install/usr/bin

@kateinoigakukun
Copy link
Member Author

@swift-ci Please test WebAssembly

@kateinoigakukun
Copy link
Member Author

@swift-ci smoke test

This change allows the Wasm stdlib to be built using the prebuilt Swift
toolchain instead of just built from source.
@kateinoigakukun kateinoigakukun force-pushed the pr-5ff3fb0d5bd5d000aa636f748af814d1607455e3 branch from 872d9e5 to 5a66841 Compare February 29, 2024 17:48
@kateinoigakukun
Copy link
Member Author

@swift-ci Please test WebAssembly

@kateinoigakukun
Copy link
Member Author

@swift-ci smoke test

@kateinoigakukun kateinoigakukun marked this pull request as ready for review March 1, 2024 02:59
@kateinoigakukun
Copy link
Member Author

I'd like to merge this within a few days to unblock my threading support works on Wasm. This change only affects wasm build and unmaintained stdlib_S_standalone_minimal_macho_x86_64, so should be safe.

@MaxDesiatov MaxDesiatov requested a review from kubamracek March 7, 2024 21:02
Copy link
Contributor

@edymtt edymtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to run the full macOS PR testing (since that will build minimal-stdlib, which uses the code path modified in utils/swift_build_support/swift_build_support/cmake.py), and the standalone stdlib PR testing (so we ensure that we are not regressing jobs using a prebuilt toolchain)

@swift-ci Please test stdlib with toolchain
@swift-ci Please test macOS platform

@kateinoigakukun
Copy link
Member Author

@swift-ci test

@kateinoigakukun
Copy link
Member Author

@swift-ci Please test stdlib with toolchain

@MaxDesiatov MaxDesiatov requested a review from edymtt March 8, 2024 16:28
@kateinoigakukun
Copy link
Member Author

https://ci.swift.org/job/swift-PR-stdlib-with-toolchain-osx/11/console
The failed tests are exactly the same as the main branch, so the build is not broken.

@kateinoigakukun kateinoigakukun merged commit cf619e2 into swiftlang:main Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants