-
Notifications
You must be signed in to change notification settings - Fork 10.6k
build: Respect native-*-tools-path when building Wasm stdlib
#71977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Respect native-*-tools-path when building Wasm stdlib
#71977
Conversation
|
@swift-ci Please test WebAssembly |
|
@swift-ci smoke test |
This change allows the Wasm stdlib to be built using the prebuilt Swift toolchain instead of just built from source.
872d9e5 to
5a66841
Compare
|
@swift-ci Please test WebAssembly |
|
@swift-ci smoke test |
|
I'd like to merge this within a few days to unblock my threading support works on Wasm. This change only affects wasm build and unmaintained |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest to run the full macOS PR testing (since that will build minimal-stdlib, which uses the code path modified in utils/swift_build_support/swift_build_support/cmake.py), and the standalone stdlib PR testing (so we ensure that we are not regressing jobs using a prebuilt toolchain)
@swift-ci Please test stdlib with toolchain
@swift-ci Please test macOS platform
|
@swift-ci test |
|
@swift-ci Please test stdlib with toolchain |
|
https://ci.swift.org/job/swift-PR-stdlib-with-toolchain-osx/11/console |
This change allows the Wasm stdlib to be built using the prebuilt Swift toolchain instead of just built from source without building compiler tools. For example, I'm using the following build preset on my local.