Ensure that proper default visibility is set for compatibility archives #71996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is set to hidden in `stdlib/CMakeLists.txt`, but in some Apple internal configurations we build the compatibility archives by directly importing `stdlib/toolchain`, thus skipping these directives and causing some symbols to become unexpected visible. Addresses rdar://73709695
|
@swift-ci please test |
|
@swift-ci please build toolchain |
|
@swift-ci Please test stdlib with toolchain |
compnerd
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is set to hidden in
stdlib/CMakeLists.txt, but in some Apple internal configurations we build the compatibility archives by directly importingstdlib/toolchain, thus skipping these directives andcausing some symbols to become unexpected visible.
Addresses rdar://73709695