Skip to content

[benchmark] Support multiple regular expression filters in Benchmark_Driver #9026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 5, 2017
Merged

[benchmark] Support multiple regular expression filters in Benchmark_Driver #9026

merged 3 commits into from
May 5, 2017

Conversation

@palimondo
Copy link
Contributor

This is a minor follow-up to #8975 Fix SR-4598 Add option to run subset of benchmarks matching a prefix.

It adds option to specify multiple prefixes and run all tests matching them. For example:

 ./Benchmark_Driver run -i 5 -f Prefix Suffix Drop

runs all the benchmarks for the Sequence interface.

@swiftix
Copy link
Contributor

swiftix commented Apr 26, 2017

@palimondo Can this new option be followed by other options or other arguments? If not, may be it is better to use multiple occurrences of -f, where each one defines a single prefix to be matched? E.g. something like:
./Benchmark_Driver run -i 5 -f Prefix -f Suffix -f Drop further arguments go here

Also, have you thought about using substrings or even regexes instead of string-based prefixes?

@atrick
Copy link
Contributor

atrick commented Apr 26, 2017

The relationship between the dashed argument '-f' and the positional arguments is unclear. Is the prefix string an argument of the '-f' option or does '-f' change the meaning of all positional arguments.

@palimondo
Copy link
Contributor Author

I was hoping it would work like that, requiring multiple -fs, and was surprised by the description

Benchmark_Driver run --help

gave out… I have to look some more at argparse documentation.

The -f argument should be exclusive with the positional BENCHMARK arguments that normally go on at the end. At least that was my goal when I put them in mutually exclusive benchmarks_group.

@palimondo
Copy link
Contributor Author

Ah, I got it. I shouldn’t have used nargs - that option specifies how many arguments get eaten. I need action=‘append’. I’ll push a fix as soon as my machine finished building master ⏲ and I can switch branch…

@palimondo
Copy link
Contributor Author

@swiftix Re: substrings and regexes, I thought about that. Got scared and ran away… I mean, prefix works for my needs, but we could play with it, now that it’s in. Do you have specific use case in mind, or just thinking in the abstract?

@palimondo
Multiple filters are specified by repeated -f
6d9de4c 
Updated usage documentation to reflect this.
@palimondo
Copy link
Contributor Author

OK, I think this should work.

Old format doesn’t work anymore and verifies that the -f and BENCHMARKs are indeed exclusive:

$ ./Benchmark_Driver run -f Prefix Suffix Drop 
usage: Benchmark_Driver run [-h] [-f PREFIX] [-t TESTS] [-o OPT]
                            [-i ITERATIONS] [--output-dir OUTPUT_DIR]
                            [--swift-repo SWIFT_REPO]
                            [BENCHMARK [BENCHMARK ...]]
Benchmark_Driver run: error: argument BENCHMARK: not allowed with argument -f/--filter

I promote this feature in initial help (given that the subcommands arguments are hidden in their respective subcommand help...):

$ ./Benchmark_Driver -h
usage: Benchmark_Driver [-h] <command> ...

optional arguments:
  -h, --help  show this help message and exit

Swift benchmark driver commands:
  <command>   See COMMAND -h for additional arguments
    submit    Run benchmarks and submit results to LNT
    run       Run benchmarks and output results to stdout
    compare   Compare benchmark results

Example: ./Benchmark_Driver run -i 5 -f Prefix -f Suffix -f Drop

And now it works like this:

$ ./Benchmark_Driver run -f Prefix -f Suffix -f Drop 
57,DropFirstAnyCollection,1,368,368,368,0,368,10629120
58,DropFirstAnyCollectionLazy,1,183753,183753,183753,0,183753,10629120
59,DropFirstAnySeqCRangeIter,1,84233,84233,84233,0,84233,10723328
...

@swiftix @atrick @gottesmm Please review.

@palimondo
Copy link
Contributor Author

Please review?

@palimondo
Copy link
Contributor Author

@swiftix Turns out, supporting regular expressions was trivial. So I've added it.
Please review. // cc @atrick @gottesmm

@palimondo palimondo changed the title Support multiple prefix filters in Benchmark_Driver Support multiple regular expression filters in Benchmark_Driver May 4, 2017
@palimondo palimondo changed the title Support multiple regular expression filters in Benchmark_Driver [benchmark] Support multiple regular expression filters in Benchmark_Driver May 4, 2017
@CodaFi
Copy link
Contributor

CodaFi commented May 4, 2017

@swift-ci please python lint

@slavapestov
Copy link
Contributor

Let's run the benchmarks just to be sure, then I will merge it.

@swift-ci Please benchmark

@slavapestov slavapestov self-assigned this May 4, 2017
@CodaFi
Copy link
Contributor

CodaFi commented May 4, 2017

He rebased this, so once more with feeling: // @shahmishal

@swift-ci please benchmark

@swift-ci
Copy link
Contributor

swift-ci commented May 5, 2017

Build comment file:

Optimized (O)

No Changes (269)
TEST OLD NEW DELTA SPEEDUP
AngryPhonebook 2945 2895 -1.7% 1.02x (?)
AnyHashableWithAClass 67790 66858 -1.4% 1.01x
Array2D 2030 2032 +0.1% 1.00x (?)
ArrayAppend 772 772 +0.0% 1.00x
ArrayAppendArrayOfInt 596 597 +0.2% 1.00x (?)
ArrayAppendAscii 23180 23179 -0.0% 1.00x (?)
ArrayAppendFromGeneric 596 596 +0.0% 1.00x
ArrayAppendGenericStructs 1233 1223 -0.8% 1.01x (?)
ArrayAppendLatin1 43574 43596 +0.1% 1.00x (?)
ArrayAppendLazyMap 935 938 +0.3% 1.00x (?)
ArrayAppendOptionals 1223 1221 -0.2% 1.00x (?)
ArrayAppendRepeatCol 836 836 +0.0% 1.00x
ArrayAppendReserved 532 533 +0.2% 1.00x (?)
ArrayAppendSequence 946 945 -0.1% 1.00x (?)
ArrayAppendStrings 13547 13546 -0.0% 1.00x (?)
ArrayAppendToFromGeneric 596 596 +0.0% 1.00x
ArrayAppendToGeneric 596 596 +0.0% 1.00x
ArrayAppendUTF16 40798 40797 -0.0% 1.00x (?)
ArrayInClass 61 62 +1.6% 0.98x (?)
ArrayLiteral 1207 1220 +1.1% 0.99x (?)
ArrayOfGenericPOD 219 219 +0.0% 1.00x
ArrayOfGenericRef 3985 3983 -0.1% 1.00x (?)
ArrayOfPOD 166 166 +0.0% 1.00x
ArrayOfRef 3904 3905 +0.0% 1.00x (?)
ArrayPlusEqualArrayOfInt 596 596 +0.0% 1.00x
ArrayPlusEqualFiveElementCollection 4640 4648 +0.2% 1.00x (?)
ArrayPlusEqualSingleElementCollection 774 774 +0.0% 1.00x
ArrayPlusEqualThreeElements 1582 1585 +0.2% 1.00x (?)
ArraySubscript 1504 1501 -0.2% 1.00x (?)
ArrayValueProp 6 6 +0.0% 1.00x
ArrayValueProp2 6 6 +0.0% 1.00x
ArrayValueProp3 6 6 +0.0% 1.00x
ArrayValueProp4 6 6 +0.0% 1.00x
BitCount 0 0 +0.0% 1.00x
ByteSwap 0 0 +0.0% 1.00x
CStringLongAscii 5061 5057 -0.1% 1.00x (?)
CStringLongNonAscii 2110 2109 -0.0% 1.00x (?)
CStringShortAscii 5235 5231 -0.1% 1.00x (?)
Calculator 43 43 +0.0% 1.00x
CaptureProp 4852 4852 +0.0% 1.00x
CharacterLiteralsLarge 8681 8675 -0.1% 1.00x (?)
CharacterLiteralsSmall 310 310 +0.0% 1.00x
Chars 1838 1838 +0.0% 1.00x
ClassArrayGetter 13 13 +0.0% 1.00x
DeadArray 182 181 -0.5% 1.01x (?)
Dictionary 573 572 -0.2% 1.00x (?)
Dictionary2 1809 1810 +0.1% 1.00x (?)
Dictionary2OfObjects 3310 3307 -0.1% 1.00x (?)
Dictionary3 454 454 +0.0% 1.00x
Dictionary3OfObjects 896 896 +0.0% 1.00x
DictionaryBridge 2596 2582 -0.5% 1.01x (?)
DictionaryLiteral 1478 1477 -0.1% 1.00x (?)
DictionaryOfObjects 2332 2332 +0.0% 1.00x
DictionaryRemove 3295 3280 -0.5% 1.00x (?)
DictionaryRemoveOfObjects 23326 23337 +0.0% 1.00x (?)
DictionarySwap 370 370 +0.0% 1.00x
DictionarySwapOfObjects 6899 6902 +0.0% 1.00x (?)
DropFirstAnyCollection 127 127 +0.0% 1.00x
DropFirstAnyCollectionLazy 44923 44880 -0.1% 1.00x (?)
DropFirstAnySeqCRangeIter 27532 27528 -0.0% 1.00x (?)
DropFirstAnySeqCRangeIterLazy 27528 27528 +0.0% 1.00x
DropFirstAnySeqCntRange 115 115 +0.0% 1.00x
DropFirstAnySeqCntRangeLazy 115 115 +0.0% 1.00x
DropFirstAnySequence 6777 6777 +0.0% 1.00x
DropFirstAnySequenceLazy 6801 6802 +0.0% 1.00x (?)
DropFirstArray 29 29 +0.0% 1.00x
DropFirstArrayLazy 29 29 +0.0% 1.00x
DropFirstCountableRange 23 23 +0.0% 1.00x
DropFirstCountableRangeLazy 23 23 +0.0% 1.00x
DropFirstSequence 3067 3067 +0.0% 1.00x
DropFirstSequenceLazy 3031 3031 +0.0% 1.00x
DropLastAnyCollection 52 52 +0.0% 1.00x
DropLastAnyCollectionLazy 14920 14921 +0.0% 1.00x (?)
DropLastAnySeqCRangeIter 4607 4607 +0.0% 1.00x
DropLastAnySeqCRangeIterLazy 4606 4605 -0.0% 1.00x (?)
DropLastAnySeqCntRange 40 40 +0.0% 1.00x
DropLastAnySeqCntRangeLazy 40 40 +0.0% 1.00x
DropLastAnySequence 6595 6598 +0.0% 1.00x (?)
DropLastAnySequenceLazy 6529 6528 -0.0% 1.00x (?)
DropLastArray 10 10 +0.0% 1.00x
DropLastArrayLazy 12 12 +0.0% 1.00x
DropLastCountableRange 8 8 +0.0% 1.00x
DropLastCountableRangeLazy 8 8 +0.0% 1.00x
DropLastSequence 516 516 +0.0% 1.00x
DropLastSequenceLazy 517 516 -0.2% 1.00x (?)
DropWhileAnyCollection 133 133 +0.0% 1.00x
DropWhileAnyCollectionLazy 96 96 +0.0% 1.00x
DropWhileAnySeqCRangeIter 22241 22238 -0.0% 1.00x (?)
DropWhileAnySeqCRangeIterLazy 96 96 +0.0% 1.00x
DropWhileAnySeqCntRange 128 128 +0.0% 1.00x
DropWhileAnySeqCntRangeLazy 96 96 +0.0% 1.00x
DropWhileAnySequence 7645 7645 +0.0% 1.00x
DropWhileAnySequenceLazy 2108 2108 +0.0% 1.00x
DropWhileArray 42 42 +0.0% 1.00x
DropWhileArrayLazy 80 80 +0.0% 1.00x
DropWhileCountableRange 35 35 +0.0% 1.00x
DropWhileCountableRangeLazy 79 79 +0.0% 1.00x
DropWhileSequence 3128 3128 +0.0% 1.00x
DropWhileSequenceLazy 76 76 +0.0% 1.00x
ErrorHandling 2863 2869 +0.2% 1.00x (?)
GlobalClass 0 0 +0.0% 1.00x
Hanoi 3430 3429 -0.0% 1.00x (?)
HashQuadratic 6022537 6030356 +0.1% 1.00x (?)
HashTest 1705 1706 +0.1% 1.00x (?)
Histogram 247 247 +0.0% 1.00x
Integrate 262 262 +0.0% 1.00x
IterateData 760 760 +0.0% 1.00x
Join 437 437 +0.0% 1.00x
LazilyFilteredArrays 64722 64737 +0.0% 1.00x (?)
LazilyFilteredRange 4017 4024 +0.2% 1.00x (?)
LinkedList 7065 7064 -0.0% 1.00x (?)
MapReduce 300 301 +0.3% 1.00x (?)
MapReduceAnyCollection 331 331 +0.0% 1.00x
MapReduceAnyCollectionShort 1995 1993 -0.1% 1.00x (?)
MapReduceClass 3075 3075 +0.0% 1.00x
MapReduceClassShort 4516 4556 +0.9% 0.99x (?)
MapReduceLazyCollection 15 15 +0.0% 1.00x
MapReduceLazyCollectionShort 44 44 +0.0% 1.00x
MapReduceLazySequence 90 90 +0.0% 1.00x
MapReduceSequence 461 460 -0.2% 1.00x (?)
MapReduceShort 1907 1906 -0.1% 1.00x (?)
MapReduceShortString 21 21 +0.0% 1.00x
MapReduceString 111 111 +0.0% 1.00x
Memset 234 234 +0.0% 1.00x
MonteCarloE 10418 10416 -0.0% 1.00x (?)
MonteCarloPi 44066 44065 -0.0% 1.00x (?)
NSDictionaryCastToSwift 5282 5275 -0.1% 1.00x (?)
NSError 290 290 +0.0% 1.00x
NSStringConversion 772 772 +0.0% 1.00x
NopDeinit 29524 29372 -0.5% 1.01x (?)
ObjectAllocation 179 179 +0.0% 1.00x
ObjectiveCBridgeFromNSArrayAnyObject 23581 23592 +0.0% 1.00x (?)
ObjectiveCBridgeFromNSArrayAnyObjectForced 4468 4468 +0.0% 1.00x
ObjectiveCBridgeFromNSArrayAnyObjectToString 43618 43696 +0.2% 1.00x (?)
ObjectiveCBridgeFromNSArrayAnyObjectToStringForced 37437 37410 -0.1% 1.00x (?)
ObjectiveCBridgeFromNSDictionaryAnyObject 117980 117481 -0.4% 1.00x (?)
ObjectiveCBridgeFromNSDictionaryAnyObjectForced 5163 5170 +0.1% 1.00x (?)
ObjectiveCBridgeFromNSDictionaryAnyObjectToString 95351 95317 -0.0% 1.00x (?)
ObjectiveCBridgeFromNSDictionaryAnyObjectToStringForced 89315 90012 +0.8% 0.99x (?)
ObjectiveCBridgeFromNSSetAnyObject 64058 64214 +0.2% 1.00x (?)
ObjectiveCBridgeFromNSSetAnyObjectForced 4180 4178 -0.0% 1.00x (?)
ObjectiveCBridgeFromNSSetAnyObjectToString 71649 71582 -0.1% 1.00x (?)
ObjectiveCBridgeFromNSSetAnyObjectToStringForced 62375 62558 +0.3% 1.00x (?)
ObjectiveCBridgeFromNSString 1409 1413 +0.3% 1.00x (?)
ObjectiveCBridgeFromNSStringForced 2345 2345 +0.0% 1.00x
ObjectiveCBridgeStubDataAppend 3700 3705 +0.1% 1.00x (?)
ObjectiveCBridgeStubDateAccess 181 181 +0.0% 1.00x
ObjectiveCBridgeStubDateMutation 272 272 +0.0% 1.00x
ObjectiveCBridgeStubFromArrayOfNSString 28468 28530 +0.2% 1.00x (?)
ObjectiveCBridgeStubFromNSDate 3673 3673 +0.0% 1.00x
ObjectiveCBridgeStubFromNSDateRef 3613 3613 +0.0% 1.00x
ObjectiveCBridgeStubFromNSString 921 916 -0.5% 1.01x (?)
ObjectiveCBridgeStubFromNSStringRef 180 176 -2.2% 1.02x (?)
ObjectiveCBridgeStubNSDataAppend 2298 2270 -1.2% 1.01x (?)
ObjectiveCBridgeStubNSDateMutationRef 12482 12406 -0.6% 1.01x (?)
ObjectiveCBridgeStubNSDateRefAccess 347 346 -0.3% 1.00x (?)
ObjectiveCBridgeStubToArrayOfNSString 29466 29703 +0.8% 0.99x (?)
ObjectiveCBridgeStubToNSDate 14474 14468 -0.0% 1.00x (?)
ObjectiveCBridgeStubToNSDateRef 3364 3394 +0.9% 0.99x (?)
ObjectiveCBridgeStubToNSString 1516 1517 +0.1% 1.00x (?)
ObjectiveCBridgeStubToNSStringRef 108 108 +0.0% 1.00x
ObjectiveCBridgeStubURLAppendPath 229166 227483 -0.7% 1.01x (?)
ObjectiveCBridgeStubURLAppendPathRef 228068 226363 -0.7% 1.01x (?)
ObjectiveCBridgeToNSArray 29561 29537 -0.1% 1.00x (?)
ObjectiveCBridgeToNSDictionary 44623 44389 -0.5% 1.01x (?)
ObjectiveCBridgeToNSSet 39039 39247 +0.5% 0.99x (?)
ObjectiveCBridgeToNSString 1271 1268 -0.2% 1.00x (?)
ObserverClosure 2284 2290 +0.3% 1.00x (?)
ObserverForwarderStruct 1132 1129 -0.3% 1.00x (?)
ObserverPartiallyAppliedMethod 3804 3790 -0.4% 1.00x (?)
ObserverUnappliedMethod 2739 2712 -1.0% 1.01x (?)
OpenClose 48 48 +0.0% 1.00x
Phonebook 9533 9535 +0.0% 1.00x (?)
PolymorphicCalls 22 22 +0.0% 1.00x
PopFrontArray 1069 1068 -0.1% 1.00x (?)
PopFrontArrayGeneric 1068 1068 +0.0% 1.00x
PopFrontUnsafePointer 8884 8886 +0.0% 1.00x (?)
PrefixAnyCollection 126 127 +0.8% 0.99x (?)
PrefixAnyCollectionLazy 44787 44816 +0.1% 1.00x (?)
PrefixAnySeqCRangeIter 21852 21848 -0.0% 1.00x (?)
PrefixAnySeqCRangeIterLazy 21845 21855 +0.0% 1.00x (?)
PrefixAnySeqCntRange 115 115 +0.0% 1.00x
PrefixAnySeqCntRangeLazy 115 115 +0.0% 1.00x
PrefixAnySequence 6090 6090 +0.0% 1.00x
PrefixAnySequenceLazy 6096 6096 +0.0% 1.00x
PrefixArray 29 29 +0.0% 1.00x
PrefixArrayLazy 29 29 +0.0% 1.00x
PrefixCountableRange 23 23 +0.0% 1.00x
PrefixCountableRangeLazy 23 23 +0.0% 1.00x
PrefixSequence 2637 2637 +0.0% 1.00x
PrefixSequenceLazy 2600 2600 +0.0% 1.00x
PrefixWhileAnyCollection 160 160 +0.0% 1.00x
PrefixWhileAnyCollectionLazy 77 77 +0.0% 1.00x
PrefixWhileAnySeqCRangeIter 12512 12511 -0.0% 1.00x (?)
PrefixWhileAnySeqCRangeIterLazy 77 77 +0.0% 1.00x
PrefixWhileAnySeqCntRange 154 154 +0.0% 1.00x
PrefixWhileAnySeqCntRangeLazy 77 77 +0.0% 1.00x
PrefixWhileAnySequence 14253 14245 -0.1% 1.00x (?)
PrefixWhileAnySequenceLazy 1585 1585 +0.0% 1.00x
PrefixWhileArray 70 70 +0.0% 1.00x
PrefixWhileArrayLazy 58 58 +0.0% 1.00x
PrefixWhileCountableRange 36 36 +0.0% 1.00x
PrefixWhileCountableRangeLazy 23 23 +0.0% 1.00x
PrefixWhileSequence 401 403 +0.5% 1.00x (?)
PrefixWhileSequenceLazy 39 39 +0.0% 1.00x
Prims 762 755 -0.9% 1.01x (?)
ProtocolDispatch 3030 3030 +0.0% 1.00x
ProtocolDispatch2 168 168 +0.0% 1.00x
RC4 168 168 +0.0% 1.00x
RGBHistogram 2293 2293 +0.0% 1.00x
RGBHistogramOfObjects 24427 24415 -0.0% 1.00x (?)
RangeAssignment 313 312 -0.3% 1.00x (?)
RecursiveOwnedParameter 2313 2311 -0.1% 1.00x (?)
ReversedArray 49 49 +0.0% 1.00x
ReversedBidirectional 29063 29107 +0.2% 1.00x (?)
ReversedDictionary 110 110 +0.0% 1.00x
SetExclusiveOr 2944 2933 -0.4% 1.00x (?)
SetExclusiveOr_OfObjects 9526 9555 +0.3% 1.00x (?)
SetIntersect 273 272 -0.4% 1.00x (?)
SetIntersect_OfObjects 1725 1726 +0.1% 1.00x (?)
SetIsSubsetOf 286 286 +0.0% 1.00x
SetIsSubsetOf_OfObjects 359 359 +0.0% 1.00x
SetUnion 2661 2641 -0.8% 1.01x (?)
SetUnion_OfObjects 8021 7986 -0.4% 1.00x (?)
SevenBoom 1465 1465 +0.0% 1.00x
Sim2DArray 276 276 +0.0% 1.00x
SortLargeExistentials 8333 8331 -0.0% 1.00x (?)
SortLettersInPlace 1143 1145 +0.2% 1.00x (?)
SortSortedStrings 860 860 +0.0% 1.00x
SortStrings 1638 1638 +0.0% 1.00x
SortStringsUnicode 7952 7953 +0.0% 1.00x (?)
StackPromo 22034 22032 -0.0% 1.00x (?)
StaticArray 21 21 +0.0% 1.00x
StrComplexWalk 984 984 +0.0% 1.00x
StrToInt 4098 4099 +0.0% 1.00x (?)
StringAdder 0 0 +0.0% 1.00x
StringBuilder 1288 1288 +0.0% 1.00x
StringBuilderLong 935 941 +0.6% 0.99x (?)
StringEdits 454455 454293 -0.0% 1.00x (?)
StringEqualPointerComparison 7309 7309 +0.0% 1.00x
StringHasPrefix 608 608 +0.0% 1.00x
StringHasPrefixUnicode 14539 14537 -0.0% 1.00x (?)
StringHasSuffix 669 671 +0.3% 1.00x (?)
StringHasSuffixUnicode 61641 61652 +0.0% 1.00x (?)
StringInterpolation 8278 8270 -0.1% 1.00x (?)
StringMatch 9061 9059 -0.0% 1.00x (?)
StringUTF16Builder 2085 2083 -0.1% 1.00x (?)
StringWalk 6188 6186 -0.0% 1.00x (?)
StringWithCString 120759 120774 +0.0% 1.00x (?)
SuffixAnyCollection 52 52 +0.0% 1.00x
SuffixAnyCollectionLazy 14970 14969 -0.0% 1.00x (?)
SuffixAnySeqCRangeIter 4928 4928 +0.0% 1.00x
SuffixAnySeqCRangeIterLazy 4928 4929 +0.0% 1.00x (?)
SuffixAnySeqCntRange 39 40 +2.6% 0.98x
SuffixAnySeqCntRangeLazy 40 40 +0.0% 1.00x
SuffixAnySequence 6779 6686 -1.4% 1.01x (?)
SuffixAnySequenceLazy 6526 6527 +0.0% 1.00x (?)
SuffixArray 10 10 +0.0% 1.00x
SuffixArrayLazy 10 10 +0.0% 1.00x
SuffixCountableRange 8 8 +0.0% 1.00x
SuffixCountableRangeLazy 8 8 +0.0% 1.00x
SuffixSequence 4465 4465 +0.0% 1.00x
SuffixSequenceLazy 4465 4465 +0.0% 1.00x
SuperChars 297266 299343 +0.7% 0.99x (?)
TwoSum 932 923 -1.0% 1.01x (?)
TypeFlood 0 0 +0.0% 1.00x
UTF8Decode 254 254 +0.0% 1.00x
Walsh 357 357 +0.0% 1.00x
XorLoop 347 347 +0.0% 1.00x
**Unoptimized (Onone)**
Regression (1)
TEST OLD NEW DELTA SPEEDUP
ArrayAppendOptionals 1295 1371 +5.9% 0.94x
No Changes (268)
TEST OLD NEW DELTA SPEEDUP
AngryPhonebook 3096 3084 -0.4% 1.00x (?)
AnyHashableWithAClass 84115 84146 +0.0% 1.00x (?)
Array2D 607951 608028 +0.0% 1.00x (?)
ArrayAppend 3789 3790 +0.0% 1.00x (?)
ArrayAppendArrayOfInt 653 652 -0.2% 1.00x (?)
ArrayAppendAscii 61548 61569 +0.0% 1.00x (?)
ArrayAppendFromGeneric 656 655 -0.2% 1.00x (?)
ArrayAppendGenericStructs 1343 1344 +0.1% 1.00x (?)
ArrayAppendLatin1 83848 83886 +0.0% 1.00x (?)
ArrayAppendLazyMap 207669 207792 +0.1% 1.00x (?)
ArrayAppendRepeatCol 213392 213377 -0.0% 1.00x (?)
ArrayAppendReserved 3887 3832 -1.4% 1.01x (?)
ArrayAppendSequence 75549 75556 +0.0% 1.00x (?)
ArrayAppendStrings 13659 13647 -0.1% 1.00x (?)
ArrayAppendToFromGeneric 654 654 +0.0% 1.00x
ArrayAppendToGeneric 655 655 +0.0% 1.00x
ArrayAppendUTF16 81509 81526 +0.0% 1.00x (?)
ArrayInClass 4734 4734 +0.0% 1.00x
ArrayLiteral 1483 1483 +0.0% 1.00x
ArrayOfGenericPOD 3077 3075 -0.1% 1.00x (?)
ArrayOfGenericRef 9590 9582 -0.1% 1.00x (?)
ArrayOfPOD 1892 1891 -0.1% 1.00x (?)
ArrayOfRef 8730 8732 +0.0% 1.00x (?)
ArrayPlusEqualArrayOfInt 653 653 +0.0% 1.00x
ArrayPlusEqualFiveElementCollection 286767 286819 +0.0% 1.00x (?)
ArrayPlusEqualSingleElementCollection 283029 286474 +1.2% 0.99x (?)
ArrayPlusEqualThreeElements 10156 10157 +0.0% 1.00x (?)
ArraySubscript 4155 4153 -0.0% 1.00x (?)
ArrayValueProp 3019 3016 -0.1% 1.00x (?)
ArrayValueProp2 3634 3657 +0.6% 0.99x (?)
ArrayValueProp3 3436 3436 +0.0% 1.00x
ArrayValueProp4 3329 3330 +0.0% 1.00x
BitCount 875 875 +0.0% 1.00x
ByteSwap 263 258 -1.9% 1.02x (?)
CStringLongAscii 5429 5416 -0.2% 1.00x (?)
CStringLongNonAscii 2416 2410 -0.2% 1.00x (?)
CStringShortAscii 8289 8313 +0.3% 1.00x (?)
Calculator 1064 1062 -0.2% 1.00x (?)
CaptureProp 110693 110761 +0.1% 1.00x (?)
CharacterLiteralsLarge 10001 9966 -0.3% 1.00x (?)
CharacterLiteralsSmall 1003 1002 -0.1% 1.00x
Chars 7396 7398 +0.0% 1.00x (?)
ClassArrayGetter 930 930 +0.0% 1.00x
DeadArray 117644 118540 +0.8% 0.99x (?)
Dictionary 1682 1681 -0.1% 1.00x (?)
Dictionary2 3481 3476 -0.1% 1.00x (?)
Dictionary2OfObjects 5771 5764 -0.1% 1.00x (?)
Dictionary3 1310 1309 -0.1% 1.00x (?)
Dictionary3OfObjects 2210 2203 -0.3% 1.00x (?)
DictionaryBridge 2694 2669 -0.9% 1.01x (?)
DictionaryLiteral 8256 8272 +0.2% 1.00x (?)
DictionaryOfObjects 4564 4582 +0.4% 1.00x (?)
DictionaryRemove 21314 21304 -0.0% 1.00x (?)
DictionaryRemoveOfObjects 55337 55192 -0.3% 1.00x (?)
DictionarySwap 5482 5484 +0.0% 1.00x (?)
DictionarySwapOfObjects 19299 19334 +0.2% 1.00x (?)
DropFirstAnyCollection 19081 19092 +0.1% 1.00x (?)
DropFirstAnyCollectionLazy 135817 136124 +0.2% 1.00x (?)
DropFirstAnySeqCRangeIter 29582 29579 -0.0% 1.00x (?)
DropFirstAnySeqCRangeIterLazy 29889 29890 +0.0% 1.00x (?)
DropFirstAnySeqCntRange 19112 19114 +0.0% 1.00x (?)
DropFirstAnySeqCntRangeLazy 19026 19021 -0.0% 1.00x (?)
DropFirstAnySequence 14010 14006 -0.0% 1.00x (?)
DropFirstAnySequenceLazy 13994 13995 +0.0% 1.00x (?)
DropFirstArray 6224 6224 +0.0% 1.00x
DropFirstArrayLazy 45195 45197 +0.0% 1.00x (?)
DropFirstCountableRange 339 339 +0.0% 1.00x
DropFirstCountableRangeLazy 39175 39163 -0.0% 1.00x (?)
DropFirstSequence 12842 12848 +0.0% 1.00x (?)
DropFirstSequenceLazy 12861 12858 -0.0% 1.00x (?)
DropLastAnyCollection 6379 6380 +0.0% 1.00x (?)
DropLastAnyCollectionLazy 45647 45606 -0.1% 1.00x (?)
DropLastAnySeqCRangeIter 44260 44259 -0.0% 1.00x (?)
DropLastAnySeqCRangeIterLazy 46156 46121 -0.1% 1.00x (?)
DropLastAnySeqCntRange 6376 6376 +0.0% 1.00x
DropLastAnySeqCntRangeLazy 6405 6402 -0.0% 1.00x (?)
DropLastAnySequence 29011 29011 +0.0% 1.00x
DropLastAnySequenceLazy 29151 29167 +0.1% 1.00x (?)
DropLastArray 2097 2097 +0.0% 1.00x
DropLastArrayLazy 15083 15082 -0.0% 1.00x (?)
DropLastCountableRange 118 118 +0.0% 1.00x
DropLastCountableRangeLazy 13002 13006 +0.0% 1.00x (?)
DropLastSequence 28653 28652 -0.0% 1.00x (?)
DropLastSequenceLazy 28586 28599 +0.0% 1.00x (?)
DropWhileAnyCollection 24919 24926 +0.0% 1.00x (?)
DropWhileAnyCollectionLazy 27255 27249 -0.0% 1.00x (?)
DropWhileAnySeqCRangeIter 31950 31956 +0.0% 1.00x (?)
DropWhileAnySeqCRangeIterLazy 27256 27254 -0.0% 1.00x (?)
DropWhileAnySeqCntRange 24865 24858 -0.0% 1.00x (?)
DropWhileAnySeqCntRangeLazy 27165 27176 +0.0% 1.00x (?)
DropWhileAnySequence 16111 16110 -0.0% 1.00x (?)
DropWhileAnySequenceLazy 12442 12443 +0.0% 1.00x (?)
DropWhileArray 9755 9777 +0.2% 1.00x (?)
DropWhileArrayLazy 16843 16842 -0.0% 1.00x (?)
DropWhileCountableRange 6142 6139 -0.0% 1.00x (?)
DropWhileCountableRangeLazy 26008 26004 -0.0% 1.00x (?)
DropWhileSequence 15021 15023 +0.0% 1.00x (?)
DropWhileSequenceLazy 11113 11114 +0.0% 1.00x (?)
ErrorHandling 3812 3735 -2.0% 1.02x (?)
GlobalClass 0 0 +0.0% 1.00x
Hanoi 17512 17596 +0.5% 1.00x (?)
HashQuadratic 48610248 48605405 -0.0% 1.00x (?)
HashTest 18591 18519 -0.4% 1.00x (?)
Histogram 8694 8698 +0.0% 1.00x (?)
Integrate 398 399 +0.3% 1.00x
IterateData 12955 12952 -0.0% 1.00x (?)
Join 1249 1248 -0.1% 1.00x (?)
LazilyFilteredArrays 1676441 1678395 +0.1% 1.00x (?)
LazilyFilteredRange 687530 687382 -0.0% 1.00x (?)
LinkedList 33124 33240 +0.4% 1.00x (?)
MapReduce 37832 37838 +0.0% 1.00x (?)
MapReduceAnyCollection 38427 38411 -0.0% 1.00x (?)
MapReduceAnyCollectionShort 50367 50420 +0.1% 1.00x (?)
MapReduceClass 43068 43072 +0.0% 1.00x (?)
MapReduceClassShort 54577 54562 -0.0% 1.00x (?)
MapReduceLazyCollection 32685 32688 +0.0% 1.00x (?)
MapReduceLazyCollectionShort 43989 43999 +0.0% 1.00x (?)
MapReduceLazySequence 25279 25256 -0.1% 1.00x (?)
MapReduceSequence 41015 41361 +0.8% 0.99x (?)
MapReduceShort 49782 50044 +0.5% 0.99x (?)
MapReduceShortString 283 282 -0.4% 1.00x (?)
MapReduceString 2605 2608 +0.1% 1.00x (?)
Memset 43956 43961 +0.0% 1.00x (?)
MonteCarloE 134989 134970 -0.0% 1.00x (?)
MonteCarloPi 52501 52533 +0.1% 1.00x (?)
NSDictionaryCastToSwift 6363 6422 +0.9% 0.99x (?)
NSError 704 712 +1.1% 0.99x (?)
NSStringConversion 1330 1325 -0.4% 1.00x (?)
NopDeinit 50347 50368 +0.0% 1.00x (?)
ObjectAllocation 634 635 +0.2% 1.00x (?)
ObjectiveCBridgeFromNSArrayAnyObject 26076 25855 -0.8% 1.01x (?)
ObjectiveCBridgeFromNSArrayAnyObjectForced 7780 7893 +1.5% 0.99x (?)
ObjectiveCBridgeFromNSArrayAnyObjectToString 45057 44907 -0.3% 1.00x (?)
ObjectiveCBridgeFromNSArrayAnyObjectToStringForced 38485 38554 +0.2% 1.00x (?)
ObjectiveCBridgeFromNSDictionaryAnyObject 121245 121967 +0.6% 0.99x (?)
ObjectiveCBridgeFromNSDictionaryAnyObjectForced 7811 7446 -4.7% 1.05x (?)
ObjectiveCBridgeFromNSDictionaryAnyObjectToString 99381 99635 +0.3% 1.00x (?)
ObjectiveCBridgeFromNSDictionaryAnyObjectToStringForced 91328 92340 +1.1% 0.99x (?)
ObjectiveCBridgeFromNSSetAnyObject 67669 66921 -1.1% 1.01x (?)
ObjectiveCBridgeFromNSSetAnyObjectForced 7241 7443 +2.8% 0.97x (?)
ObjectiveCBridgeFromNSSetAnyObjectToString 77067 76582 -0.6% 1.01x (?)
ObjectiveCBridgeFromNSSetAnyObjectToStringForced 66240 66056 -0.3% 1.00x (?)
ObjectiveCBridgeFromNSString 4066 4069 +0.1% 1.00x (?)
ObjectiveCBridgeFromNSStringForced 2749 2747 -0.1% 1.00x (?)
ObjectiveCBridgeStubDataAppend 3667 3708 +1.1% 0.99x (?)
ObjectiveCBridgeStubDateAccess 1002 1002 +0.0% 1.00x
ObjectiveCBridgeStubDateMutation 515 515 +0.0% 1.00x
ObjectiveCBridgeStubFromArrayOfNSString 28936 28850 -0.3% 1.00x (?)
ObjectiveCBridgeStubFromNSDate 4096 4095 -0.0% 1.00x (?)
ObjectiveCBridgeStubFromNSDateRef 3943 3946 +0.1% 1.00x (?)
ObjectiveCBridgeStubFromNSString 984 986 +0.2% 1.00x (?)
ObjectiveCBridgeStubFromNSStringRef 216 216 +0.0% 1.00x
ObjectiveCBridgeStubNSDataAppend 2601 2623 +0.8% 0.99x (?)
ObjectiveCBridgeStubNSDateMutationRef 15679 15358 -2.0% 1.02x (?)
ObjectiveCBridgeStubNSDateRefAccess 1204 1204 +0.0% 1.00x
ObjectiveCBridgeStubToArrayOfNSString 28990 29488 +1.7% 0.98x (?)
ObjectiveCBridgeStubToNSDate 15057 15114 +0.4% 1.00x (?)
ObjectiveCBridgeStubToNSDateRef 3394 3396 +0.1% 1.00x (?)
ObjectiveCBridgeStubToNSString 1575 1574 -0.1% 1.00x (?)
ObjectiveCBridgeStubToNSStringRef 155 155 +0.0% 1.00x
ObjectiveCBridgeStubURLAppendPath 232081 237993 +2.5% 0.98x (?)
ObjectiveCBridgeStubURLAppendPathRef 229958 233726 +1.6% 0.98x (?)
ObjectiveCBridgeToNSArray 29544 29488 -0.2% 1.00x (?)
ObjectiveCBridgeToNSDictionary 45108 44978 -0.3% 1.00x (?)
ObjectiveCBridgeToNSSet 39567 39995 +1.1% 0.99x (?)
ObjectiveCBridgeToNSString 1308 1306 -0.2% 1.00x (?)
ObserverClosure 6632 6636 +0.1% 1.00x (?)
ObserverForwarderStruct 4685 4690 +0.1% 1.00x (?)
ObserverPartiallyAppliedMethod 8085 8097 +0.1% 1.00x (?)
ObserverUnappliedMethod 8406 8411 +0.1% 1.00x (?)
OpenClose 416 416 +0.0% 1.00x
Phonebook 24732 24719 -0.1% 1.00x (?)
PolymorphicCalls 2942 2940 -0.1% 1.00x (?)
PopFrontArray 9847 9844 -0.0% 1.00x (?)
PopFrontArrayGeneric 8828 8827 -0.0% 1.00x (?)
PopFrontUnsafePointer 98139 97777 -0.4% 1.00x (?)
PrefixAnyCollection 19108 19125 +0.1% 1.00x (?)
PrefixAnyCollectionLazy 136513 135948 -0.4% 1.00x (?)
PrefixAnySeqCRangeIter 24013 24019 +0.0% 1.00x (?)
PrefixAnySeqCRangeIterLazy 24118 24117 -0.0% 1.00x (?)
PrefixAnySeqCntRange 19115 19113 -0.0% 1.00x (?)
PrefixAnySeqCntRangeLazy 19031 19033 +0.0% 1.00x (?)
PrefixAnySequence 11803 11800 -0.0% 1.00x (?)
PrefixAnySequenceLazy 11792 11795 +0.0% 1.00x (?)
PrefixArray 6239 6239 +0.0% 1.00x
PrefixArrayLazy 45200 45204 +0.0% 1.00x (?)
PrefixCountableRange 339 339 +0.0% 1.00x
PrefixCountableRangeLazy 39074 39087 +0.0% 1.00x (?)
PrefixSequence 10778 10775 -0.0% 1.00x (?)
PrefixSequenceLazy 10727 10725 -0.0% 1.00x (?)
PrefixWhileAnyCollection 36578 36562 -0.0% 1.00x (?)
PrefixWhileAnyCollectionLazy 22447 22451 +0.0% 1.00x (?)
PrefixWhileAnySeqCRangeIter 40749 40767 +0.0% 1.00x (?)
PrefixWhileAnySeqCRangeIterLazy 22397 22408 +0.0% 1.00x (?)
PrefixWhileAnySeqCntRange 36468 36465 -0.0% 1.00x (?)
PrefixWhileAnySeqCntRangeLazy 22735 22734 -0.0% 1.00x (?)
PrefixWhileAnySequence 29513 29507 -0.0% 1.00x (?)
PrefixWhileAnySequenceLazy 11205 11207 +0.0% 1.00x (?)
PrefixWhileArray 16817 16821 +0.0% 1.00x (?)
PrefixWhileArrayLazy 14664 14678 +0.1% 1.00x (?)
PrefixWhileCountableRange 17601 17596 -0.0% 1.00x (?)
PrefixWhileCountableRangeLazy 21751 21747 -0.0% 1.00x (?)
PrefixWhileSequence 28368 28371 +0.0% 1.00x (?)
PrefixWhileSequenceLazy 10446 10448 +0.0% 1.00x (?)
Prims 8961 9003 +0.5% 1.00x (?)
ProtocolDispatch 7191 7201 +0.1% 1.00x (?)
ProtocolDispatch2 489 489 +0.0% 1.00x
RC4 20233 20232 -0.0% 1.00x (?)
RGBHistogram 33926 33933 +0.0% 1.00x (?)
RGBHistogramOfObjects 99254 98659 -0.6% 1.01x (?)
RangeAssignment 5755 5743 -0.2% 1.00x (?)
RecursiveOwnedParameter 9653 9641 -0.1% 1.00x (?)
ReversedArray 589 589 +0.0% 1.00x
ReversedBidirectional 75507 75593 +0.1% 1.00x (?)
ReversedDictionary 26477 26474 -0.0% 1.00x (?)
SetExclusiveOr 21165 21175 +0.0% 1.00x (?)
SetExclusiveOr_OfObjects 41153 41111 -0.1% 1.00x (?)
SetIntersect 10801 10802 +0.0% 1.00x (?)
SetIntersect_OfObjects 11224 11208 -0.1% 1.00x (?)
SetIsSubsetOf 1627 1628 +0.1% 1.00x (?)
SetIsSubsetOf_OfObjects 1513 1513 +0.0% 1.00x
SetUnion 12010 12005 -0.0% 1.00x (?)
SetUnion_OfObjects 29602 29646 +0.1% 1.00x (?)
SevenBoom 1595 1592 -0.2% 1.00x (?)
Sim2DArray 30032 30036 +0.0% 1.00x (?)
SortLargeExistentials 17913 17935 +0.1% 1.00x (?)
SortLettersInPlace 2863 2856 -0.2% 1.00x (?)
SortSortedStrings 1412 1411 -0.1% 1.00x (?)
SortStrings 2521 2522 +0.0% 1.00x (?)
SortStringsUnicode 8966 8962 -0.0% 1.00x (?)
StackPromo 102781 103085 +0.3% 1.00x (?)
StaticArray 4646 4657 +0.2% 1.00x
StrComplexWalk 5973 5976 +0.1% 1.00x (?)
StrToInt 5145 5141 -0.1% 1.00x (?)
StringAdder 49 48 -2.0% 1.02x
StringBuilder 2725 2719 -0.2% 1.00x (?)
StringBuilderLong 1099 1099 +0.0% 1.00x
StringEdits 735960 741787 +0.8% 0.99x (?)
StringEqualPointerComparison 10021 10025 +0.0% 1.00x (?)
StringHasPrefix 1729 1732 +0.2% 1.00x (?)
StringHasPrefixUnicode 16409 16404 -0.0% 1.00x (?)
StringHasSuffix 1920 1916 -0.2% 1.00x (?)
StringHasSuffixUnicode 63601 63597 -0.0% 1.00x (?)
StringInterpolation 11858 11852 -0.1% 1.00x (?)
StringMatch 30520 30517 -0.0% 1.00x (?)
StringUTF16Builder 3569 3570 +0.0% 1.00x (?)
StringWalk 21965 21954 -0.1% 1.00x (?)
StringWithCString 126373 126366 -0.0% 1.00x (?)
SuffixAnyCollection 6368 6370 +0.0% 1.00x (?)
SuffixAnyCollectionLazy 45537 45359 -0.4% 1.00x (?)
SuffixAnySeqCRangeIter 41888 41915 +0.1% 1.00x (?)
SuffixAnySeqCRangeIterLazy 41924 41913 -0.0% 1.00x (?)
SuffixAnySeqCntRange 6378 6379 +0.0% 1.00x (?)
SuffixAnySeqCntRangeLazy 6410 6410 +0.0% 1.00x
SuffixAnySequence 26862 26858 -0.0% 1.00x (?)
SuffixAnySequenceLazy 26925 26929 +0.0% 1.00x (?)
SuffixArray 2094 2097 +0.1% 1.00x (?)
SuffixArrayLazy 15080 15081 +0.0% 1.00x (?)
SuffixCountableRange 118 118 +0.0% 1.00x
SuffixCountableRangeLazy 12993 13000 +0.1% 1.00x (?)
SuffixSequence 26419 26414 -0.0% 1.00x (?)
SuffixSequenceLazy 26404 26420 +0.1% 1.00x (?)
SuperChars 333184 334814 +0.5% 1.00x (?)
TwoSum 4337 4344 +0.2% 1.00x (?)
TypeFlood 161 165 +2.5% 0.98x (?)
UTF8Decode 36929 36924 -0.0% 1.00x (?)
Walsh 11980 11973 -0.1% 1.00x (?)
XorLoop 23707 23708 +0.0% 1.00x (?)
**Hardware Overview** Model Name: Mac mini Model Identifier: Macmini7,1 Processor Name: Intel Core i5 Processor Speed: 2.8 GHz Number of Processors: 1 Total Number of Cores: 2 L2 Cache (per Core): 256 KB L3 Cache: 3 MB Memory: 16 GB

@shahmishal
Copy link
Member

@swift-ci Please smoke test

@palimondo palimondo mentioned this pull request May 5, 2017
Merged
@palimondo
Copy link
Contributor Author

Smoke test failed on python lint. But the "@swift-ci python lint" was successful? 🤷‍♂️🤦‍♂️
Looks like someone should have a look at that…

I have amended the python lint fixes and force pushed. @shahmishal Please rerun the smoke test.

@CodaFi
Copy link
Contributor

CodaFi commented May 5, 2017

@swift-ci please smoke test

@palimondo
Copy link
Contributor Author

Can this be merged?

@atrick atrick self-requested a review May 5, 2017 16:20
atrick
atrick approved these changes May 5, 2017
View reviewed changes
Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahmishal shahmishal merged commit a05b35c into swiftlang:master May 5, 2017
@shahmishal
Copy link
Member

@palimondo thanks!!

@palimondo palimondo deleted the SR-4598 branch May 5, 2017 16:53
@palimondo palimondo mannequin mentioned this pull request May 15, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atrick atrick atrick approved these changes

Assignees

@slavapestov slavapestov

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@palimondo @swiftix @atrick @CodaFi @slavapestov @swift-ci @shahmishal