-
Couldn't load subscription status.
- Fork 10.6k
[benchmark] SR-4572 Remove jinja2 dependency from test harness generation #9193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'm thinking about reducing those 3 methods for adding test in main.swift to one with the appropriate list parameter… |
e87d73c to
11b80c8
Compare
|
Please review. @swift-ci Please benchmark |
|
@swift-ci Please benchmark |
1 similar comment
|
@swift-ci Please benchmark |
|
@palimondo You need commit access to request CI. Once you've got a few PRs merged you can ask for commit access (email code-owners@swift.org with your github username and a list of five merged PRs). |
|
Looks good to me if the benchmark suite completes without error. |
Build comment file:Optimized (O) Regression (9)
Improvement (11)
No Changes (249)
Improvement (2)
No Changes (267)
|
|
@swift-ci Please smoke test |
|
@slavapestov Please merge? |
|
Thank you @slavapestov ! |
I've replaced jinja2 with GYB, as requested by @dabrahams in review of #8641
Resolves SR-4572.