Merge pull request #10 from appwrite/tests

Author: ItzNotABug

.dockerignore

@@ -15,6 +15,7 @@ LICENSE
 # Test artifacts
 test-screenshots/
 comparison/
+.lighthouse/
 
 # Build output
 dist/

.github/workflows/check.yml

@@ -3,26 +3,23 @@ name: "Check"
 on:
   pull_request:
   push:
-    branches: [main]
+    branches: [ main ]
 
 jobs:
   check:
     name: "Check"
     runs-on: ubuntu-latest
     steps:
       - name: Checkout code
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
-      - name: Set up Node.js
-        uses: actions/setup-node@v2
+      - name: Setup Bun
+        uses: oven-sh/setup-bun@v1
         with:
-          node-version: '18'
-
-      - name: Install PNPM
-        run: npm i -g pnpm
+          bun-version: 'latest'
 
       - name: Install dependencies
-        run: pnpm install
+        run: bun install --frozen-lockfile
 
-      - name: Format
-        run: pnpm run check
+      - name: ESLint check
+        run: bun run check

.github/workflows/lint.yml

@@ -3,26 +3,23 @@ name: "Lint"
 on:
   pull_request:
   push:
-    branches: [main]
+    branches: [ main ]
 
 jobs:
   lint:
     name: "Lint"
     runs-on: ubuntu-latest
     steps:
       - name: Checkout code
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
-      - name: Set up Node.js
-        uses: actions/setup-node@v2
+      - name: Setup Bun
+        uses: oven-sh/setup-bun@v1
         with:
-          node-version: '18'
-
-      - name: Install PNPM
-        run: npm i -g pnpm
+          bun-version: 'latest'
 
       - name: Install dependencies
-        run: pnpm install
+        run: bun install --frozen-lockfile
 
-      - name: Format
-        run: pnpm run lint
+      - name: Biome lint
+        run: bun run lint

.github/workflows/test.yml

@@ -0,0 +1,50 @@
+name: "Test"
+
+on:
+  pull_request:
+  push:
+    branches: [ main ]
+
+jobs:
+  tests:
+    name: "Unit and E2E Tests"
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Setup Bun
+        uses: oven-sh/setup-bun@v1
+        with:
+          bun-version: 'latest'
+
+      - name: Install dependencies
+        run: bun install --frozen-lockfile
+
+      - name: Run unit tests
+        run: bun test:unit
+
+      - name: Start container
+        run: docker compose up -d
+
+      - name: Wait for container to be ready
+        run: |
+          for i in {1..30}; do
+            if curl -f http://localhost:3000/v1/health > /dev/null 2>&1; then
+              echo "Container is ready!"
+              exit 0
+            fi
+            echo "Waiting for container... ($i/30)"
+            sleep 1
+          done
+          echo "Container failed to start"
+          echo "Container logs:"
+          docker compose logs
+          exit 1
+
+      - name: Run e2e tests
+        run: bun test:e2e
+
+      - name: Print logs
+        if: failure()
+        run: docker compose logs

.gitignore

@@ -144,3 +144,5 @@ dist
 # Test artifacts
 test-screenshots/
 comparison/
+.lighthouse/
+lighthouse/

Dockerfile

@@ -17,8 +17,7 @@ RUN apk upgrade --no-cache --available && \
       tini && \
     apk add --no-cache font-wqy-zenhei --repository=http://dl-cdn.alpinelinux.org/alpine/edge/community && \
     # remove unnecessary chromium files to save space
-    rm -rf /usr/lib/chromium/chrome_crashpad_handler \
-           /usr/lib/chromium/chrome_200_percent.pak \
+    rm -rf /usr/lib/chromium/chrome_200_percent.pak \
            /usr/lib/chromium/chrome_100_percent.pak \
            /usr/lib/chromium/xdg-mime \
            /usr/lib/chromium/xdg-settings \
@@ -31,11 +30,14 @@ ENV PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD=1 \
     NODE_ENV=production
 
 WORKDIR /app
-USER chrome
 
 COPY package.json ./
 COPY --from=base /app/node_modules ./node_modules
 COPY src/ ./src/
 
+RUN chown -R chrome:chrome /app
+
+USER chrome
+
 ENTRYPOINT ["tini", "--"]
 CMD ["bun", "run", "src/server.ts"]

package.json

@@ -9,15 +9,17 @@
 		"dev": "bun --watch src/server.ts",
 		"build": "tsc",
 		"type-check": "tsc --noEmit",
-		"format": "biome check --write ./src",
-		"lint": "biome check ./src",
-		"check": "eslint ./src",
-		"test": "echo \"Error: no test specified\" && exit 1"
+		"format": "biome check --write ./src ./tests",
+		"lint": "biome check ./src ./tests",
+		"check": "eslint ./src ./tests",
+		"test": "bun test",
+		"test:e2e": "bun test tests/e2e",
+		"test:unit": "bun test tests/unit"
 	},
 	"keywords": [],
 	"author": "",
 	"license": "ISC",
-	"packageManager": "pnpm@10.20.0",
+	"packageManager": "bun@1.3.2",
 	"dependencies": {
 		"lighthouse": "^12.2.1",
 		"playwright-core": "^1.52.0",

src/config/index.ts

@@ -1,4 +1,4 @@
 export * from "./browser.js";
 export * from "./lighthouse.js";
 
-export const port = Number(process.env.PORT) || 3000;
+export const port = process.env.PORT ? Number(process.env.PORT) : 3000;

src/routes/reports.ts

@@ -1,9 +1,11 @@
-import type { BrowserContextOptions } from "playwright-core";
+import type { BrowserContext, BrowserContextOptions } from "playwright-core";
 import { playAudit } from "playwright-lighthouse";
 import { browser, defaultContext, lighthouseConfigs } from "../config";
 import { lighthouseSchema } from "../schemas";
 
 export async function handleReportsRequest(req: Request): Promise<Response> {
+	let context: BrowserContext | undefined;
+
 	try {
 		const json = await req.json();
 		const body = lighthouseSchema.parse(json);
@@ -19,7 +21,7 @@ export async function handleReportsRequest(req: Request): Promise<Response> {
 		if (body.locale) contextOptions.locale = body.locale;
 		if (body.timezoneId) contextOptions.timezoneId = body.timezoneId;
 
-		const context = await browser.newContext(contextOptions);
+		context = await browser.newContext(contextOptions);
 
 		// Grant permissions if specified
 		if (body.permissions && body.permissions.length > 0) {
@@ -72,7 +74,6 @@ export async function handleReportsRequest(req: Request): Promise<Response> {
 			thresholds,
 		});
 
-		await context.close();
 		const report = Array.isArray(results.report)
 			? results.report.join("")
 			: results.report;
@@ -85,5 +86,7 @@ export async function handleReportsRequest(req: Request): Promise<Response> {
 			status: 400,
 			headers: { "Content-Type": "application/json" },
 		});
+	} finally {
+		await context?.close();
 	}
 }

src/routes/screenshots.ts

@@ -1,4 +1,5 @@
 import type {
+	BrowserContext,
 	BrowserContextOptions,
 	PageScreenshotOptions,
 } from "playwright-core";
@@ -8,6 +9,8 @@ import { screenshotSchema } from "../schemas";
 export async function handleScreenshotsRequest(
 	req: Request,
 ): Promise<Response> {
+	let context: BrowserContext | undefined;
+
 	try {
 		const json = await req.json();
 		const body = screenshotSchema.parse(json);
@@ -28,7 +31,7 @@ export async function handleScreenshotsRequest(
 		if (body.timezoneId) contextOptions.timezoneId = body.timezoneId;
 		if (body.geolocation) contextOptions.geolocation = body.geolocation;
 
-		const context = await browser.newContext(contextOptions);
+		context = await browser.newContext(contextOptions);
 
 		// Grant permissions if specified
 		if (body.permissions && body.permissions.length > 0) {
@@ -78,8 +81,6 @@ export async function handleScreenshotsRequest(
 
 		const screen = await page.screenshot(screenshotOptions);
 
-		await context.close();
-
 		return new Response(Buffer.from(screen), {
 			headers: {
 				"Content-Type": `image/${body.format}`,
@@ -91,5 +92,7 @@ export async function handleScreenshotsRequest(
 			status: 400,
 			headers: { "Content-Type": "application/json" },
 		});
+	} finally {
+		await context?.close();
 	}
 }