Skip to content
This repository was archived by the owner on Sep 29, 2023. It is now read-only.

Add error codes #139

Merged
merged 36 commits into from
Feb 16, 2022
Merged

Add error codes #139

merged 36 commits into from
Feb 16, 2022

Conversation

christyjacob4
Copy link
Contributor

@christyjacob4 christyjacob4 commented Feb 6, 2022 •
edited
Loading

Screenshot 2022-02-07 at 3 15 18 AM

kodumbeats and others added 17 commits January 10, 2022 14:46
@kodumbeats
fix: OR queries require an array of values
46ed598
@eldadfux
Merge pull request #129 from appwrite/fix-database-query-examples
9297ac2 
Fix: OR queries require an array of values
@eldadfux
Updated migration docs
f3a3f33
@eldadfux
Merge pull request #132 from appwrite/fix-migration-can-use-multi-thr…
75b9789 
…eads

Updated migration docs
@eldadfux
Clarification for updade script location
1028c36
@eldadfux
Stop and uninstall added
1906af0
@eldadfux @Meldiron
Update app/views/docs/installation.phtml
c5540b0 
Co-authored-by: Matej Bačo <matejbaco2000@gmail.com>
@eldadfux
Merge pull request #133 from appwrite/fix-upgrade-docs-uninstall
2651225 
Fix upgrade docs and added stop + uninstall
@Meldiron
Update main.phtml
5f5ed43
@Meldiron
Syntax bug fix
1404eb0
@eldadfux
Merge pull request #134 from appwrite/fix-broken-link
3a424c7 
Fix broken specs docs
@Meldiron
New function syntax
015ec6d
@Meldiron
Merge pull request #135 from appwrite/fix-broken-link
456c63a 
Specs bug fix
@eldadfux
Fixed indexes case
6c3577d
@eldadfux
Merge pull request #136 from appwrite/fix-indexes-lowercase
420f367 
Fixed indexes case
@christyjacob4
feat: add support for custom error codes
d5b0316
@christyjacob4
feat: update variable name
fbe3b74
@christyjacob4 christyjacob4 mentioned this pull request Feb 6, 2022
Closed
eldadfux
eldadfux suggested changes Feb 7, 2022
View reviewed changes
Copy link
Member

@eldadfux eldadfux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should we do with the 1st table in the page? I feel the difference between them is not very clear for the reader.

@christyjacob4
Copy link
Contributor Author

@eldadfux the first table talks about the convention we follow when deciding an HTTP status code for our errors. And the second table talks more about Appwrite specific error codes.

@eldadfux
Copy link
Member

eldadfux commented Feb 8, 2022

I would only consider adding the version we started supporting each error code. We have something similar for env vars.

@eldadfux eldadfux requested a review from gewenyu99 February 8, 2022 08:31
@christyjacob4 christyjacob4 mentioned this pull request Feb 8, 2022
Merged
@christyjacob4
Copy link
Contributor Author

@eldadfux In this case, I'm not sure we can follow the convention we use for ENV Vars.
Screenshot 2022-02-08 at 7 41 46 PM

Since we introduced all these error codes in 0.13. literally every row in the table will have this information and it'll just make the table very noisy.

It's probably a better option to mention that this feature was introduced in 0.13 once in one of the paragraphs above.

From 0.14 onwards, we can start following the ENV Vars convention

@christyjacob4
Copy link
Contributor Author

christyjacob4 commented Feb 8, 2022 •
edited
Loading

Screenshot 2022-02-08 at 8 46 53 PM

@eldadfux updated the description to add the note

gewenyu99
gewenyu99 approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@gewenyu99 gewenyu99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM <3

@christyjacob4
Copy link
Contributor Author

Latest Preview

Screenshot 2022-02-09 at 2 49 56 AM

Meldiron
Meldiron approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@Meldiron Meldiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eldadfux eldadfux changed the base branch from main to 0.13 February 14, 2022 06:22
@eldadfux
Copy link
Member

Changed target branch to 0.13

@eldadfux eldadfux merged commit 431bed8 into 0.13 Feb 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
3 more reviewers

@eldadfux eldadfux eldadfux approved these changes

@Meldiron Meldiron Meldiron approved these changes

@gewenyu99 gewenyu99 gewenyu99 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@christyjacob4 @eldadfux @Meldiron @gewenyu99 @kodumbeats