[v0.16.0] backport: dead cgroups fix #3326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain kubernetes version make use of short lived cgroups for various tasks (for example log rotation). These cgroups will generate events and a very quick cgroup_rmdir event. As such, many related events to the cgroup will attempt to query its directory through the recursive path and not find it. Commit adds a "Dead" field to the cgroup info to indicate a cgroup which has already been removed. Various logical sections can refer to it if its relevant to them, and more importantly, additional queries will not be attempted. Bonus: optimize away additional Stat syscall in containers by returning the directory ctime in cgroup.GetCgroupPath. commit: 0c5719a (main), cherry-pick
josedonizetti
approved these changes
Jul 19, 2023
|
I'll merge it tmr, and release 0.16.2 |
| @@ -389,10 +390,12 @@ func GetCgroupControllerHierarchy(subsys string) (int, error) { | |||
| // given cgroupId and subPath (related to cgroup fs root dir). If subPath is | |||
| // empty, then all directories from cgroup fs will be searched for the given | |||
| // cgroupId. | |||
| func GetCgroupPath(rootDir string, cgroupId uint64, subPath string) (string, error) { | |||
| // | |||
| // Returns found cgroup path, its ctime, and an error if relevant | |||
There was a problem hiding this comment.
nit: godoc formatting requires function name as the first string (I know this is a backport and has been merged already).
rafaeldtinoco
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #3325