Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: pluggable datasources #3737

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

josedonizetti
Copy link
Contributor

@josedonizetti josedonizetti commented Dec 5, 2023

Fix #3705

@josedonizetti josedonizetti changed the title gfeature: pluggable datasources feature: pluggable datasources Dec 6, 2023
@josedonizetti josedonizetti force-pushed the pugglable-datasources branch 2 times, most recently from 84f9a9f to 7d3e934 Compare December 6, 2023 19:36
@josedonizetti josedonizetti force-pushed the pugglable-datasources branch 3 times, most recently from 227ecf7 to 7953705 Compare December 6, 2023 20:01
@josedonizetti josedonizetti marked this pull request as ready for review December 6, 2023 20:11
tests/e2e-inst-signatures/export.go Show resolved Hide resolved
pkg/signatures/signature/signature.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@NDStrahilevitz NDStrahilevitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, take note of the log change I suggested, but otherwise +1 from me.

pkg/signatures/signature/signature.go Outdated Show resolved Hide resolved
Co-authored-by: Nadav Strahilevitz <nd.strahilevitz@gmail.com>
@rafaeldtinoco rafaeldtinoco merged commit c780a06 into aquasecurity:main Dec 11, 2023
3 of 4 checks passed
@josedonizetti josedonizetti deleted the pugglable-datasources branch December 13, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ExportedDataSources to .so plugins
3 participants