feat(signatures): expose signatures helpers as Go module #3765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will require a follow-up PR to remove the |
AlonZivony
force-pushed
the
feature/signatures-go-module
branch
from
6c974d9
to
cd02df1
Compare
|
Please see my comment #3705 (comment) |
|
Using signatures as an .so or built in is not so important to determine what to do here in my opinion. |
NDStrahilevitz
approved these changes
Dec 18, 2023
rafaeldtinoco
requested review from
yanivagman
and removed request for
rafaeldtinoco
AlonZivony
force-pushed
the
feature/signatures-go-module
branch
from
cd02df1
to
b3e3a4c
Compare
yanivagman
approved these changes
Jan 22, 2024
| @@ -180,3 +181,7 @@ require ( | |||
| gopkg.in/yaml.v3 v3.0.1 // indirect | |||
| kernel.org/pub/linux/libs/security/libcap/psx v1.2.68 // indirect | |||
| ) | |||
|
|
|||
| replace github.com/aquasecurity/tracee/signatures/helpers => ./signatures/helpers | |||
There was a problem hiding this comment.
Please replace this after merged
yanivagman
requested changes
Jan 22, 2024
AlonZivony
force-pushed
the
feature/signatures-go-module
branch
2 times, most recently
from
36bafa3
to
4db321b
Compare
To allow users the option to use the up-to-date helpers for Go signatures, the helpers were exported to be an external Go module.
AlonZivony
force-pushed
the
feature/signatures-go-module
branch
from
4db321b
to
3c9b1e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
To allow users the option to use the up-to-date helpers for Go signatures, the helpers were exported to be an external Go module.
f9a60e590 feat(signatures): expose signatures helpers as Go module
2. Explain how to test it
3. Other comments