-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(signatures): expose signatures helpers as Go module #3765
feat(signatures): expose signatures helpers as Go module #3765
Conversation
This will require a follow-up PR to remove the |
6c974d9
to
cd02df1
Compare
Please see my comment #3705 (comment) |
Using signatures as an .so or built in is not so important to determine what to do here in my opinion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, i'm +1 for this change.
cd02df1
to
b3e3a4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -180,3 +181,7 @@ require ( | |||
gopkg.in/yaml.v3 v3.0.1 // indirect | |||
kernel.org/pub/linux/libs/security/libcap/psx v1.2.68 // indirect | |||
) | |||
|
|||
replace github.com/aquasecurity/tracee/signatures/helpers => ./signatures/helpers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace this after merged
36bafa3
to
4db321b
Compare
To allow users the option to use the up-to-date helpers for Go signatures, the helpers were exported to be an external Go module.
4db321b
to
3c9b1e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1. Explain what the PR does
To allow users the option to use the up-to-date helpers for Go signatures, the helpers were exported to be an external Go module.
f9a60e590 feat(signatures): expose signatures helpers as Go module
2. Explain how to test it
3. Other comments