fix(events): fix ftrace_hook #3896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@OriGlassman I have this PR #3848 related to Events States. I think it's worth taking a look just to catch on upcoming changes. |
OriGlassman
force-pushed
the
fix_ftrace_event
branch
from
55e9066 to
83a9378
Compare
AlonZivony
approved these changes
Feb 25, 2024
| } | ||
|
|
||
| uniqueHooksMap[key] = struct{}{} | ||
|
|
||
| log(definition.GetName(), p.GetProgramName()) |
There was a problem hiding this comment.
I know this is not part of the current code, but shouldn't we use the logger.Infow here?
There was a problem hiding this comment.
This is a change done by a previous maintainer so not sure the about motivation
We need to count how many ftrace based hooks will be placed on each symbol. eventsState may contain duplicate events due to dependencies. To get the real count, we consider the program name and the prob type. Furthermore, added logic that addresses the situation where there may be multiple k[ret]probes from a single probe request (due to multiple symbols at different locations).
OriGlassman
force-pushed
the
fix_ftrace_event
branch
from
83a9378 to
fead5f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
We need to count how many ftrace based hooks will be placed on each symbol. eventsState may contain duplicate events due to dependencies. To get the real count, we consider the program name and the prob type. Furthermore, added logic that addresses the situation where there may be multiple k[ret]probes from a single probe request (due to multiple symbols at different locations).
2. Explain how to test it
./tracee -e=ftrace_hook
3. Other comments