Concurrency issue at analyze #3907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rscampos
force-pushed
the
analyze_concurrency
branch
from
d26335e to
311ae37
Compare
- produce close the engineInput instead of close producerFinished, in this way the engine knows when the events finishes - add a close in the function consumeSources, in this way the consumer knows when Finding finishes
rscampos
force-pushed
the
analyze_concurrency
branch
from
311ae37 to
5b5426e
Compare
|
Going to review this now. 👍🏼 |
|
The issues are reproducible indeed. |
geyslan
approved these changes
Mar 6, 2024
AlonZivony
previously requested changes
Mar 19, 2024
rscampos
force-pushed
the
analyze_concurrency
branch
from
50d48d2 to
e879b11
Compare
|
Many thanks @rscampos for your help on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
fix: #3903
fix: #3905
Instead of terminating the program upon reaching the EOF (after all events have been read), ensure the program concludes only after all events have been fully processed.
2. Explain how to test it
3. Other comments