chore: use map instead of stack to store task_info #3920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we use the stack to initialize task_info in the sched_process_fork program. Since task_info_t has a size of ~200 bytes, we should opt to put it on a map, and not on the stack.
yanivagman
force-pushed
the
sched_process_fork_less_mem
branch
from
07947a4 to
dbb3ff6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
Currently we use the stack to initialize task_info in the sched_process_fork program. Since task_info_t has a size of ~200 bytes, we should opt to put it on a map, and not on the stack.
"Replace me with
make check-proutput"2. Explain how to test it
3. Other comments