fix: show argv on failed execve events #3922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanivagman
force-pushed
the
fix_execve_failed_nil_args
branch
from
7aab36a to
24c73ed
Compare
AlonZivony
reviewed
Mar 25, 2024
Agree. Let's merge this PR since it is a required fix and I tested it manually. |
yanivagman
force-pushed
the
fix_execve_failed_nil_args
branch
from
24c73ed to
7e0d737
Compare
Failed execve calls never showed argv nor envp. That is since it was handled by the generic syscall handler, which doesn't handle string array arguments. Fix by adding a dedicated handler at execve(at) exit.
yanivagman
force-pushed
the
fix_execve_failed_nil_args
branch
from
7e0d737 to
ee22c8c
Compare
AlonZivony
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
Failed execve calls never showed argv nor envp.
That is since it was handled by the generic syscall handler, which doesn't handle string array arguments.
Fix by adding a dedicated handler at execve(at) exit.
"Replace me with
make check-proutput"2. Explain how to test it
3. Other comments
Fix: #2847