refactor: move to the new pyroscope package #3927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pyroscope has moved to the grafana org
06kellyjac
force-pushed
the
migrate_pyroscope
branch
from
3cafd75 to
879c05e
Compare
|
Why does the checklist ask users to label the PR when non-contributors can't label the PR? |
Gonna check this. 👍🏼 |
I approved it to run workflow. Check again if you can set labels. If not, it's not an issue anyway since it's being set automatically. |
|
Yeah, still un-editable for me
|
|
Thanks for the feedback. |
|
Thanks for merging 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
Resolves grafana/pyroscope#1941
879c05e refactor: move to the new pyroscope package
Note:
make check-prassumes/bin/shisbashbecause it uses square brackets2. Explain how to test it
Build tracee. Run the profiling
3. Other comments