Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make check-pr compliant with different shells #3929

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

geyslan
Copy link
Member

@geyslan geyslan commented Mar 25, 2024

Close: #3928

1. Explain what the PR does

ea5e6f4 fix: make check-pr compliant with different shells

It also now deals with trailing newlines in the commit bodies, printing
them following the same pattern.

2. Explain how to test it

3. Other comments

It also now deals with trailing newlines in the commit bodies, printing
them following the same pattern.
Copy link
Collaborator

@yanivagman yanivagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geyslan geyslan merged commit 572d42c into aquasecurity:main Mar 25, 2024
3 checks passed
@geyslan geyslan deleted the make-check-pr branch June 28, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make check-pr is broken for shells but bash
2 participants