fix: proper fragment delimiters in webhook URL #3943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation uses '?' as the delimiter for the fragment part of the URL. Tracee fails to read it, and logs this error: Error: printer.(*webhookEventPrinter).Init: unable to convert timeout value "3s?gotemplate=... Signed-off-by: Nicolas Degory <nicolas.degory@gmail.com>
|
@josedonizetti this PR is ready for review |
josedonizetti
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
2. Explain how to test it
Legacy way to pass a webhook worked with proper URLs (http://hostname:port?query[&fragment1][&fragment2]
This reproduces it in the code converting the config to flags.
3. Other comments
I have NOT compiled and tested this code (the Makefile is not Apple silicon friendly), but I ran the tests: