Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing nodeSelector and tolerations to tracee-operator #3944

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

ndegory
Copy link
Contributor

@ndegory ndegory commented Mar 29, 2024

1. Explain what the PR does

Allow options to schedule the tracee operator when deploying with the Helm chart

  • fix: add missing nodeSelector and tolerations to tracee-operator deployment
  • fix: add missing imagePullSecrets for tracee-operator

2. Explain how to test it

cat > test.yaml <<EOF
operator:
  nodeSelector:
    kubernetes.io/os: linux
  tolerations:
    - key: "workload"
      operator: "Equal"
      value: "security"
      effect: "NoSchedule"
EOF
helm template tracee ./deploy/helm/tracee --show-only templates/deploy.yaml
# shows no tolerations and no nodeSelect
helm template tracee ./deploy/helm/tracee --show-only templates/deploy.yaml -f test.yaml
# shows the specified nodeSelector and tolerations

3. Other comments

…oyment

Signed-off-by: Nicolas Degory <nicolas.degory@gmail.com>
Signed-off-by: Nicolas Degory <nicolas.degory@gmail.com>
@ndegory
Copy link
Contributor Author

ndegory commented Mar 29, 2024

@josedonizetti this PR is ready for review, thank you

@josedonizetti josedonizetti merged commit 935ad01 into aquasecurity:main Apr 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants