Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: various co-re fixes #3952

Merged
merged 1 commit into from
Apr 4, 2024
Merged

chore: various co-re fixes #3952

merged 1 commit into from
Apr 4, 2024

Conversation

yanivagman
Copy link
Collaborator

@yanivagman yanivagman commented Apr 3, 2024 •
edited
Loading

1. Explain what the PR does

This PR changes a few bpf_probe_read which did not use the correct core/kernel helpers.

2. Explain how to test it

3. Other comments

Close: #559

@geyslan
Copy link
Member

geyslan commented Apr 3, 2024

make -f ./builder/Makefile.checkers fmt-fix https://github.com/aquasecurity/tracee/actions/runs/8536669681/job/23385677420?pr=3952

@yanivagman yanivagman force-pushed the various_core_fixes branch from d2087fc to 79e5658 Compare April 3, 2024 13:16
@yanivagman yanivagman changed the title chore: various core fixes chore: various co-re fixes Apr 4, 2024
@yanivagman yanivagman requested a review from geyslan April 4, 2024 08:42
geyslan
geyslan reviewed Apr 4, 2024
View reviewed changes
Copy link
Member

@geyslan geyslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some questions.

pkg/ebpf/c/common/cgroups.h Show resolved Hide resolved
pkg/ebpf/c/tracee.bpf.c Show resolved Hide resolved
pkg/ebpf/c/tracee.bpf.c Show resolved Hide resolved
pkg/ebpf/c/tracee.bpf.c Show resolved Hide resolved
pkg/ebpf/c/tracee.bpf.c Show resolved Hide resolved
pkg/ebpf/c/tracee.bpf.c Show resolved Hide resolved
geyslan
geyslan approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@geyslan geyslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanivagman yanivagman merged commit 3ddf73d into aquasecurity:main Apr 4, 2024
32 checks passed
@yanivagman yanivagman deleted the various_core_fixes branch April 4, 2024 14:39
@NDStrahilevitz NDStrahilevitz mentioned this pull request May 2, 2024
Closed
@yanivagman yanivagman mentioned this pull request May 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geyslan geyslan geyslan approved these changes

Assignees

@yanivagman yanivagman

Labels
area/ebpf kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use bpf_probe_read_user and bpf_probe_read_kernel helpers
2 participants
@yanivagman @geyslan