fix(dependencies): allow multiple removes of same event #3961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a bug of nil pointer reference when removing an event node from the dependencies after it was already removed.
Use the new dependencies manager to cancel events with missing ksymbols dependencies.
Whenever choose an event, add all its dependencies to the eventsState to submit. The dependencies watcher is only triggered when an event is added to the tree, so it can't be relied upon to add dependencies to state for each policy.
AlonZivony
force-pushed
the
bugfix/allow-remove-event-twice-dependencies
branch
3 times, most recently
from
b51787c to
1af29e8
Compare
AlonZivony
force-pushed
the
bugfix/allow-remove-event-twice-dependencies
branch
from
055de86 to
b7f8000
Compare
geyslan
reviewed
Apr 4, 2024
|
E2E 1446 is green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
Fix a bug of nil pointer reference when removing an event node from the dependencies after it was already removed.
2. Explain how to test it
3. Other comments