fix(analyze): bind flags with viper #3981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlonZivony
force-pushed
the
bugfix/analyze-unbound-flags
branch
from
597d102 to
d092436
Compare
AlonZivony
force-pushed
the
bugfix/analyze-unbound-flags
branch
2 times, most recently
from
044ea38 to
f2890e0
Compare
geyslan
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
LGTM, tested the returned flags and they seem to work nicely.
This seems not related to your PR but would be nice to have a better output in these cases:
sudo ./dist/tracee analyze
Error: accepts 1 arg(s), received 0
sudo ./dist/tracee analyze -l -e anti_debugging events.json
Error: accepts 1 arg(s), received 2
Restore the binding of the analyze mode flags with viper. This should fix the issue that they weren't usable since they were commented out.
Changed print to logger and added some more information to it.
The first case is OK in my opinion. |
AlonZivony
force-pushed
the
bugfix/analyze-unbound-flags
branch
from
f2890e0 to
9d66b4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
Restore the binding of the analyze mode flags with viper. This should fix the issue that they weren't usable since they were commented out.
Fix #3980
2. Explain how to test it
3. Other comments