Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix helm install option webhook #3984

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

rscampos
Copy link
Collaborator

@rscampos rscampos commented Apr 17, 2024

1. Explain what the PR does

37fd480 docs: helm add repo is not necessary from local installation
58824a3 fix: option webhook value on helm

58824a3 fix: option webhook value on helm

If uses helm chart to install Tracee, the '--output' key need to be
separeted from value 'webhook' in order to work as excepted.

2. Explain how to test it

Follow this tutorial, the issue raises during helm install tracee step.

3. Other comments

If uses helm chart to install Tracee, the '--output' key need to be
separeted from value 'webhook' in order to work as excepted.
@rscampos rscampos force-pushed the fix_helm_install_option_webhook branch from f973a73 to 37fd480 Compare April 17, 2024 19:39
@rscampos rscampos marked this pull request as ready for review April 17, 2024 19:44
Copy link
Member

@geyslan geyslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geyslan
Copy link
Member

geyslan commented Apr 17, 2024

@rscampos thanks. Please, before merging it, take a look at this #3942 to see if it's related to yours.

@rscampos
Copy link
Collaborator Author

Thank you for the review @geyslan, as far as I understood #3942 has no conflict with that

@rscampos rscampos merged commit 82519a1 into aquasecurity:main Apr 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants