Wait for apt locks #4000
Merged
Wait for apt locks #4000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce the window of opportunity for apt-get to fail due to locks by calling wait_for_apt_locks before each apt-get command.
- SC2086: Double quote to prevent globbing and word splitting.
- SC2005: Useless echo? Instead of 'cmd; echo $?' just use 'cmd'.
- SC2001: See if you can use ${variable//search/replace} instead.
In this was used % (shortest match - suffix) since it's more appropriate
for the use case.
Silence shellcheck SC1091 in e2e-install-deps.sh.
|
a4475b8 is a fix attempt for #3945 (comment) The other commits are timely. |
|
The shellcheck fixes seem to be OK, I've double checked each one. I'll take a look wait_for_apt_locks before apt's. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
d4a0dfa fix(tests): address shellcheck SC1091
95ea66a fix(tests): address shellcheck SC2001
3700b40 fix(tests): address shellcheck SC2005
d06ef23 fix(tests): address shellcheck SC2086
a4475b8 fix(tests): call wait_for_apt_locks before apt-get
2. Explain how to test it
3. Other comments