[v0.21.0] capture: fixes and tests #4023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 3ddf73d changed various probe_read calls to probe_read_kernel. However, io capture relies on reading userspace buffers, as such the pointers being read are userspace pointers. Therefore the relevant calls in some of these changes, affecting IO capture, were changed to probe_read_user. commit: e08d553 (main), cherry-pick
Add an e2e instrumentation test for the vfs_writev event. Due to the event being broken on some kernels, it is currently disabled (missing in declaration in pr.yaml). commit: ce26df3 (main), cherry-pick
commit: d89195c (main), cherry-pick
NDStrahilevitz
force-pushed
the
io_capture_fix_v0.21.0
branch
from
44b987a to
e9224fa
Compare
yanivagman
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting to merge #4016 so that the mainline commits can be specified in the commit messages.