Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rem logger and errfmt as deps from env pkg #4129

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

geyslan
Copy link
Member

@geyslan geyslan commented Jun 17, 2024

Close: #4111

1. Explain what the PR does

1d8278c chore: rem logger and errfmt as dependencies

Remove logger and errfmt as dependencies from the environment package.

2. Explain how to test it

3. Other comments

Remove logger and errfmt as dependencies from the environment package.
@geyslan geyslan requested a review from yanivagman June 17, 2024 14:18
@geyslan geyslan self-assigned this Jun 17, 2024
@geyslan geyslan changed the title chore: rem logger and errfmt as dependencies from environment chore: rem logger and errfmt as deps from env pkg Jun 17, 2024
@geyslan geyslan marked this pull request as ready for review June 17, 2024 14:34
@geyslan geyslan closed this Jun 28, 2024
@geyslan geyslan deleted the env-dep-removal branch June 28, 2024 18:26
@geyslan geyslan restored the env-dep-removal branch June 28, 2024 18:47
@geyslan geyslan reopened this Jun 28, 2024
Copy link
Collaborator

@yanivagman yanivagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geyslan geyslan merged commit 841c2c1 into aquasecurity:main Jun 30, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependencies of pkg/utils/environment
2 participants