fix: generic kubernetes containerd path pattern #4155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geyslan
approved these changes
Jun 26, 2024
pkg/containers/containers.go
Outdated
| @@ -294,6 +294,13 @@ func getContainerIdFromCgroup(cgroupPath string) (string, cruntime.RuntimeId, bo | |||
| // non-systemd docker with format in GitHub Actions: .../actions_job/01adbf...f26db7f/ | |||
| runtime = cruntime.Docker | |||
| } | |||
| if runtime == cruntime.Unknown && i > 0 && strings.HasPrefix(cgroupParts[i-1], "pod") { | |||
There was a problem hiding this comment.
We are referring to cgroupParts[i-1] for the third time. Maybe buffer it at the beginning of this matched branch?
NDStrahilevitz
force-pushed
the
3003_unknwon_container_runtime
branch
from
1eb711c to
81cc9bf
Compare
Some containerd+k8s distribution create containers in cgroup paths with the format of: kubepods/<besteffort|burstable>/podXXXX/<container_id> This pattern is unrecognizable and on its face indistinguishable between container runtimes. Since it has so far only been observed in containerd distributions, detect it as such (for now).
NDStrahilevitz
force-pushed
the
3003_unknwon_container_runtime
branch
from
81cc9bf to
f73adee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
1eb711c: fix: generic kubernetes containerd path pattern
2. Explain how to test it
Test on a GKE env.
3. Other comments
Fix #3003