Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sig): define signature metadata statically #4237

Merged

Conversation

rscampos
Copy link
Collaborator

@rscampos rscampos commented Aug 7, 2024

1. Explain what the PR does

5ddbc4d core(test): static sig metadata declaration
4a5dbbb chore: static sig metadata declaration

4a5dbbb chore: static sig metadata declaration

Compared to the previous method of defining metadata, using static
signature metadata declaration has been shown to improve performance by
approximately 20% to 30%, according to benchmark results.

2. Explain how to test it

3. Other comments

The results of the benchmark is explained in this PR #4223

@rscampos rscampos requested a review from geyslan August 7, 2024 19:33
@rscampos rscampos self-assigned this Aug 7, 2024
@rscampos rscampos force-pushed the chore_signature_metadata_golang branch 2 times, most recently from 4e9c20c to a1ceedd Compare August 7, 2024 19:44
Compared to the previous method of defining metadata, using static
signature metadata declaration has been shown to improve performance by
approximately 20% to 30%, according to benchmark results.
@rscampos rscampos force-pushed the chore_signature_metadata_golang branch from a1ceedd to 5ddbc4d Compare August 7, 2024 20:02
Copy link
Member

@geyslan geyslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rscampos rscampos merged commit 5a4d505 into aquasecurity:main Aug 9, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants