Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow override of containerd namespace #3060

Conversation

pmengelbert
Copy link
Contributor

@pmengelbert pmengelbert commented Oct 20, 2022

Description

Containerd allows you to specify a namespace for queries, pulls, storage, etc. Trivy currently only scans local images in the default containerd namespace. This PR enables trivy to scan other namespaces within the containerd store.

An excellent use case is scanning the containerd store on kubernetes clusters; by default, images used by kubernetes are pulled to the k8s.io namespace.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options) does not introduce new options
  • I've included a "before" and "after" example to the description (if the PR is a user interface change). not a UI change

@pmengelbert pmengelbert requested a review from knqyf263 as a code owner October 20, 2022 20:57
@CLAassistant
Copy link

CLAassistant commented Oct 20, 2022

CLA assistant check
All committers have signed the CLA.

@pmengelbert
Copy link
Contributor Author

Had to rebase after main branch updated. Will need re-approval for the integration test workflow, please and thanks :)

@knqyf263
Copy link
Collaborator

Thanks for your contribution! Do you mind if I ask you to resolve the conflict?

Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
@pmengelbert pmengelbert force-pushed the feat/override_default_containerd_namespace branch from 7d0adde to 7828d58 Compare October 26, 2022 13:23
@pmengelbert
Copy link
Contributor Author

Thanks for your contribution! Do you mind if I ask you to resolve the conflict?

@knqyf263 Done! Will you please re-approve the test workflow? Thanks

@knqyf263 knqyf263 merged commit b6cef12 into aquasecurity:main Oct 27, 2022
@knqyf263
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support CONTAINERD_NAMESPACE environment variable
3 participants