-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support scan remote repository #3131
feat: support scan remote repository #3131
Conversation
@knqyf263 Hi, please take a look this pr. This feature is very useful for me. Thank you! And I think this is both a bug or a new feature, and I'm not sure if this feature is something you forgot to implement or is on your future features. |
@afdesk hi, Can you take a look at the CI error report? |
hi @pikaqiu-go yes, sure. i'll take a look at this CI error |
@afdesk thank you! |
Hi, @afdesk Thank you for reviewing the code for me. If it's not urgent, I can try to finish them. |
Should I finsh them in this pr, maybe I can finish them in the new pr. Do I need to create issue and associate pr? |
it'll be really cool! thanks a lot!
Could you finish them in this PR? I'm ready to help you in any time! |
OK~ |
hi, @afdesk,please take a look~ |
I'm not sure if integration test is right. |
@pikaqiu-go thanks. I'm taking a look right now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@pikaqiu-go I've updated the test data. I hope it's OK. |
@knqyf263 I was a bit confused that Trivy doesn't have an integration test for |
Oh, yes, we don't have integration tests for repository scanning since it used to be almost the same as fs scanning. |
@knqyf263 Hi, this pr has been stagnant for a long time. I wonder if there are other problems? |
@pikaqiu-go Thanks for your contribution🙏 |
Description
support scan remote repository through the deployed vulnerability database server. The detail see in #3121 .
Related issues
Checklist