Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): pass arbitrary env vars to trivy #3208

Merged
merged 1 commit into from
Nov 29, 2022
Merged

feat(helm): pass arbitrary env vars to trivy #3208

merged 1 commit into from
Nov 29, 2022

Conversation

jouve
Copy link
Contributor

@jouve jouve commented Nov 21, 2022

Description

fix #3206

with the following values.yaml

trivy:
  extraEnvVars:
    FOO: bar
    TOTO: |
      titi
      multi
      line

the chart has the following diff in the configmap:

@@ -47,6 +47,11 @@
   TRIVY_DEBUG: "false"
   TRIVY_SKIP_UPDATE: "false"
   TRIVY_DB_REPOSITORY: "ghcr.io/aquasecurity/trivy-db"
+  FOO: bar
+  TOTO: |
+    titi
+    multi
+    line

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • [] I've updated the documentation with the relevant information (if needed).
  • [x ] I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@jouve jouve requested a review from chen-keinan as a code owner November 21, 2022 20:37
@CLAassistant
Copy link

CLAassistant commented Nov 21, 2022

CLA assistant check
All committers have signed the CLA.

@knqyf263
Copy link
Collaborator

@chen-keinan Could you take a look?

@chen-keinan
Copy link
Contributor

@jouve lgtm 🚀

@knqyf263 knqyf263 merged commit b1a2c4e into aquasecurity:main Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pass arbitrary env vars with the helm chart
4 participants