Clean dependencies #816
Merged
Clean dependencies #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macor161
reviewed
Oct 11, 2019
| "internal-ip": "^4.3.0", | ||
| "ipfs-api": "^26.1.2", | ||
| "ipfs-http-client": "^33.0.1", | ||
| "js-sha3": "^0.8.0", |
There was a problem hiding this comment.
I think js-sha3 is still used at a couple of places.
There was a problem hiding this comment.
Good catch forgot to update to use web3.utils
| @@ -35,7 +35,6 @@ cmd.middleware(MIDDLEWARES) | |||
|
|
|||
| cmd.alias('env', 'environment') | |||
| cmd.alias('h', 'help') | |||
| cmd.alias('v', 'version') | |||
There was a problem hiding this comment.
Is there a particular reason to remove this?
There was a problem hiding this comment.
Oh this cause what we discuss here: aragon/aragen#79 (comment)
There was a problem hiding this comment.
Ah ok I wasn't aware of the issue between aragon -v and aragon devchain -v, thanks 🙂
However aragon devchain -v doesn't seem to be working either, is this normal?
There was a problem hiding this comment.
Oh sorry about that, it was cause I needed to update aragen first. I did that yesterday
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦅 Pull Request
I decided to include this PR to clean a bit before moving to v7 and start the separation of packages.
Update to client
v0.8.2@macor161 would you mind take a look?