fixed edge not-found error handling

Author: rashtao

core/src/main/java/com/arangodb/internal/ArangoEdgeCollectionAsyncImpl.java

@@ -20,21 +20,23 @@
 
 package com.arangodb.internal;
 
-import com.arangodb.*;
+import com.arangodb.ArangoDBException;
+import com.arangodb.ArangoEdgeCollectionAsync;
+import com.arangodb.ArangoGraphAsync;
 import com.arangodb.entity.EdgeEntity;
 import com.arangodb.entity.EdgeUpdateEntity;
 import com.arangodb.model.*;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.CompletionException;
+
+import static com.arangodb.internal.ArangoErrors.*;
 
 /**
  * @author Mark Vollmary
  */
 public class ArangoEdgeCollectionAsyncImpl extends InternalArangoEdgeCollection implements ArangoEdgeCollectionAsync {
 
-    private static final Logger LOGGER = LoggerFactory.getLogger(ArangoEdgeCollectionAsyncImpl.class);
     private final ArangoGraphAsync graph;
 
     protected ArangoEdgeCollectionAsyncImpl(final ArangoGraphAsyncImpl graph, final String name) {
@@ -70,27 +72,24 @@ public CompletableFuture<EdgeEntity> insertEdge(final Object value, final EdgeCr
 
     @Override
     public <T> CompletableFuture<T> getEdge(final String key, final Class<T> type) {
-        return executorAsync().execute(() -> getEdgeRequest(key, new GraphDocumentReadOptions()),
-                        getEdgeResponseDeserializer(type))
-                .exceptionally(e -> {
-                    // FIXME
-                    if (LOGGER.isDebugEnabled()) {
-                        LOGGER.debug(e.getMessage(), e);
-                    }
-                    return null;
-                });
-
+        return getEdge(key, type, null);
     }
 
     @Override
     public <T> CompletableFuture<T> getEdge(final String key, final Class<T> type, final GraphDocumentReadOptions options) {
         return executorAsync().execute(() -> getEdgeRequest(key, options), getEdgeResponseDeserializer(type))
-                .exceptionally(e -> {
-                    // FIXME
-                    if (LOGGER.isDebugEnabled()) {
-                        LOGGER.debug(e.getMessage(), e);
+                .exceptionally(err -> {
+                    Throwable e = err instanceof CompletionException ? err.getCause() : err;
+                    if (e instanceof ArangoDBException) {
+                        ArangoDBException aEx = (ArangoDBException) e;
+                        if (matches(aEx, 304)
+                                || matches(aEx, 404, ERROR_ARANGO_DOCUMENT_NOT_FOUND)
+                                || matches(aEx, 412, ERROR_ARANGO_CONFLICT)
+                        ) {
+                            return null;
+                        }
                     }
-                    return null;
+                    throw ArangoDBException.of(e);
                 });
     }
 

core/src/main/java/com/arangodb/internal/ArangoEdgeCollectionImpl.java

@@ -26,16 +26,14 @@
 import com.arangodb.entity.EdgeEntity;
 import com.arangodb.entity.EdgeUpdateEntity;
 import com.arangodb.model.*;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
+
+import static com.arangodb.internal.ArangoErrors.*;
 
 /**
  * @author Mark Vollmary
  */
 public class ArangoEdgeCollectionImpl extends InternalArangoEdgeCollection implements ArangoEdgeCollection {
 
-    private static final Logger LOGGER = LoggerFactory.getLogger(ArangoEdgeCollectionImpl.class);
-
     private final ArangoGraphImpl graph;
 
     protected ArangoEdgeCollectionImpl(final ArangoGraphImpl graph, final String name) {
@@ -71,28 +69,21 @@ public EdgeEntity insertEdge(final Object value, final EdgeCreateOptions options
 
     @Override
     public <T> T getEdge(final String key, final Class<T> type) {
-        // FIXME
-        try {
-            return executorSync().execute(getEdgeRequest(key, new GraphDocumentReadOptions()),
-                    getEdgeResponseDeserializer(type));
-        } catch (final ArangoDBException e) {
-            if (LOGGER.isDebugEnabled()) {
-                LOGGER.debug(e.getMessage(), e);
-            }
-            return null;
-        }
+        return getEdge(key, type, null);
     }
 
     @Override
     public <T> T getEdge(final String key, final Class<T> type, final GraphDocumentReadOptions options) {
-        // FIXME
         try {
             return executorSync().execute(getEdgeRequest(key, options), getEdgeResponseDeserializer(type));
         } catch (final ArangoDBException e) {
-            if (LOGGER.isDebugEnabled()) {
-                LOGGER.debug(e.getMessage(), e);
+            if (matches(e, 304)
+                    || matches(e, 404, ERROR_ARANGO_DOCUMENT_NOT_FOUND)
+                    || matches(e, 412, ERROR_ARANGO_CONFLICT)
+            ) {
+                return null;
             }
-            return null;
+            throw e;
         }
     }
 

driver/src/test/java/com/arangodb/ArangoEdgeCollectionTest.java

@@ -22,7 +22,6 @@
 
 import com.arangodb.entity.*;
 import com.arangodb.model.*;
-import com.arangodb.util.TestUtils;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.Arguments;