Skip to content

Commit eda129b

Browse files
committed
[DE-436] reuse code in shaded integration tests
1 parent 2bcb2ba commit eda129b

File tree

9 files changed

+45
-53
lines changed

9 files changed

+45
-53
lines changed

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ jobs:
129129
- name: Info
130130
run: mvn -version
131131
- name: Test
132-
run: mvn -e --no-transfer-progress -am -pl driver test -Dtest=com.arangodb.util.UnicodeUtilsTest -Dsurefire.failIfNoSpecifiedTests=false
132+
run: mvn -e --no-transfer-progress -am -pl driver test -Dtest=graalvm.UnicodeUtilsTest -Dsurefire.failIfNoSpecifiedTests=false
133133

134134
test-jwt:
135135
timeout-minutes: 20

driver/pom.xml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -157,12 +157,6 @@
157157
<version>22.3.0</version>
158158
<scope>test</scope>
159159
</dependency>
160-
<dependency>
161-
<groupId>ru.lanwen.verbalregex</groupId>
162-
<artifactId>java-verbal-expressions</artifactId>
163-
<version>1.8</version>
164-
<scope>test</scope>
165-
</dependency>
166160
<dependency>
167161
<groupId>io.smallrye.config</groupId>
168162
<artifactId>smallrye-config-core</artifactId>

driver/src/test/java/com/arangodb/PackageVersionTest.java

Lines changed: 3 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -5,31 +5,16 @@
55
import org.junit.jupiter.params.ParameterizedTest;
66
import org.junit.jupiter.params.provider.EnumSource;
77

8-
import static ru.lanwen.verbalregex.VerbalExpression.regex;
9-
10-
import ru.lanwen.verbalregex.VerbalExpression;
11-
128
import static org.assertj.core.api.Assertions.assertThat;
139
import static org.junit.jupiter.api.Assumptions.assumeTrue;
1410

1511
class PackageVersionTest extends BaseJunit5 {
1612

13+
private static final String EXPECTED_VERSION = "7.0.0-ALPHA.2";
14+
1715
@Test
1816
void packageVersion() {
19-
VerbalExpression testRegex = regex()
20-
.startOfLine()
21-
// major
22-
.digit().atLeast(1)
23-
.then(".")
24-
// minor
25-
.digit().atLeast(1)
26-
.then(".")
27-
// patch
28-
.digit().atLeast(1)
29-
.maybe(regex().anything())
30-
.endOfLine()
31-
.build();
32-
assertThat(PackageVersion.VERSION).matches(testRegex.toString());
17+
assertThat(PackageVersion.VERSION).isEqualTo(EXPECTED_VERSION);
3318
}
3419

3520
@ParameterizedTest

driver/src/test/java/com/arangodb/config/ConfigUtils.java

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,7 @@
11
package com.arangodb.config;
22

3-
import io.smallrye.config.PropertiesConfigSourceProvider;
4-
import io.smallrye.config.SmallRyeConfig;
5-
import io.smallrye.config.SmallRyeConfigBuilder;
6-
73
public class ConfigUtils {
84

9-
public static ArangoConfigProperties loadConfigMP() {
10-
return loadConfigMP("arangodb.properties");
11-
}
12-
13-
public static ArangoConfigProperties loadConfigMP(final String location) {
14-
return loadConfigMP(location, "arangodb");
15-
}
16-
17-
public static ArangoConfigProperties loadConfigMP(final String location, final String prefix) {
18-
SmallRyeConfig cfg = new SmallRyeConfigBuilder()
19-
.withSources(new PropertiesConfigSourceProvider(location, ConfigUtils.class.getClassLoader(), false))
20-
.withMapping(ArangoConfigPropertiesMPImpl.class, prefix)
21-
.build();
22-
return cfg.getConfigMapping(ArangoConfigPropertiesMPImpl.class, prefix);
23-
}
24-
255
public static ArangoConfigProperties loadConfig() {
266
return ArangoConfigProperties.fromFile();
277
}

driver/src/test/java/com/arangodb/util/UnicodeUtilsTest.java renamed to driver/src/test/java/graalvm/UnicodeUtilsTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
1-
package com.arangodb.util;
1+
package graalvm;
22

33
import com.arangodb.internal.util.EncodeUtils;
4+
import com.arangodb.util.TestUtils;
5+
import com.arangodb.util.UnicodeUtils;
46
import org.graalvm.home.Version;
57
import org.graalvm.nativeimage.ImageInfo;
68
import org.graalvm.polyglot.Context;
Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
1-
package com.arangodb.config;
1+
package mp;
22

33
import com.arangodb.Protocol;
4+
import com.arangodb.config.ArangoConfigProperties;
5+
import com.arangodb.config.HostDescription;
46
import com.arangodb.entity.LoadBalancingStrategy;
57

68
import java.util.List;

driver/src/test/java/com/arangodb/config/ConfigDefaultsTest.java renamed to driver/src/test/java/mp/ConfigMPDefaultsTest.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,17 @@
1-
package com.arangodb.config;
1+
package mp;
22

3+
import com.arangodb.config.ArangoConfigProperties;
34
import org.junit.jupiter.api.Test;
45
import org.junit.jupiter.api.condition.DisabledInNativeImage;
56

67
import static org.assertj.core.api.Assertions.assertThat;
78

89
@DisabledInNativeImage
9-
class ConfigDefaultsTest {
10+
class ConfigMPDefaultsTest {
1011

1112
@Test
1213
void defaultValues() {
13-
ArangoConfigProperties config = ConfigUtils.loadConfigMP("arangodb.properties", "wrong");
14+
ArangoConfigProperties config = ConfigUtilsMP.loadConfigMP("arangodb.properties", "wrong");
1415
checkResult(config);
1516
}
1617

driver/src/test/java/com/arangodb/config/ConfigTest.java renamed to driver/src/test/java/mp/ConfigMPTest.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
1-
package com.arangodb.config;
1+
package mp;
22

33
import com.arangodb.Protocol;
4+
import com.arangodb.config.ArangoConfigProperties;
5+
import com.arangodb.config.HostDescription;
46
import com.arangodb.entity.LoadBalancingStrategy;
57
import org.assertj.core.api.InstanceOfAssertFactories;
68
import org.junit.jupiter.api.Test;
@@ -9,7 +11,7 @@
911
import static org.assertj.core.api.Assertions.assertThat;
1012

1113
@DisabledInNativeImage
12-
class ConfigTest {
14+
class ConfigMPTest {
1315
private final HostDescription hostA = new HostDescription("aaa", 1111);
1416
private final HostDescription hostB = new HostDescription("bbb", 2222);
1517
private final Protocol protocol = Protocol.HTTP_VPACK;
@@ -30,7 +32,7 @@ class ConfigTest {
3032

3133
@Test
3234
void readConfig() {
33-
ArangoConfigProperties config = ConfigUtils.loadConfigMP("arangodb-config-test.properties", "adb");
35+
ArangoConfigProperties config = ConfigUtilsMP.loadConfigMP("arangodb-config-test.properties", "adb");
3436
checkResult(config);
3537
}
3638

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
package mp;
2+
3+
import com.arangodb.config.ArangoConfigProperties;
4+
import io.smallrye.config.PropertiesConfigSourceProvider;
5+
import io.smallrye.config.SmallRyeConfig;
6+
import io.smallrye.config.SmallRyeConfigBuilder;
7+
8+
public class ConfigUtilsMP {
9+
10+
public static ArangoConfigProperties loadConfigMP() {
11+
return loadConfigMP("arangodb.properties");
12+
}
13+
14+
public static ArangoConfigProperties loadConfigMP(final String location) {
15+
return loadConfigMP(location, "arangodb");
16+
}
17+
18+
public static ArangoConfigProperties loadConfigMP(final String location, final String prefix) {
19+
SmallRyeConfig cfg = new SmallRyeConfigBuilder()
20+
.withSources(new PropertiesConfigSourceProvider(location, ConfigUtilsMP.class.getClassLoader(), false))
21+
.withMapping(ArangoConfigPropertiesMPImpl.class, prefix)
22+
.build();
23+
return cfg.getConfigMapping(ArangoConfigPropertiesMPImpl.class, prefix);
24+
}
25+
26+
}

0 commit comments

Comments
 (0)