Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing interaction between energy potentials and supply system operation #3543

Conversation

MatNif
Copy link
Collaborator

@MatNif MatNif commented Apr 5, 2024

When performing the 'cascading' activation of the components installed in the supply system, the previous code would erroneously look at the availability of the demand from renewable energy potentials and grids independently of the component category.

This has now been fixed. With the new code:

  • Main cooling/heating components (i.e. primary components) would check if their demand could be met by potentials or the grid prior to activation.
  • Supply components (i.e. secondary components) would check if their demand can be satisfied by the remaining renewable energy potentials and/or the grid.
  • Lastly, heat rejection components (i.e. tertiary components) would check if the heat they need to reject can be directly expulsed to the environment prior to their activation.

Additionally, a mistake was fixed for cogeneration plants, where the wrong energy carriers were attributed to their outputs.

Previously every time a category of components was operated the water-filling-principal method would check if the energy demand could be drawn from available energy potentials instead of supplying that energy using the components. This lead to false operating calculations since systems would try to draw energy that actually needed to be rejected instead. This newly introduced change should fix that.
Energy carriers were wrongly attributed to inputs and outputs of the CogenPlant component type, leading to a bug while matching energy flows for the supply system operation.
@MatNif MatNif linked an issue Apr 5, 2024 that may be closed by this pull request
@jimenofonseca
Copy link
Contributor

jimenofonseca commented Apr 5, 2024 via email

@MatNif
Copy link
Collaborator Author

MatNif commented Apr 5, 2024

Hi @jimenofonseca,

I'm sorry I missed this message. Let's check it sometime next week. How about Monday at 9 a.m. CET?

@reyery
Copy link
Member

reyery commented Apr 18, 2024

@MatNif the PR looks good to me. Do you have anything else to change? If not I would merge it.

@MatNif
Copy link
Collaborator Author

MatNif commented Apr 18, 2024

@MatNif the PR looks good to me. Do you have anything else to change? If not I would merge it.

No, nothing else to add. You can go ahead and merge.

@reyery reyery merged commit 7a04e48 into master Apr 18, 2024
7 checks passed
@reyery reyery deleted the 3542-optimisation-heat-rejection-components-are-not-operated-correctly branch April 18, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimisation: Heat rejection components are not operated correctly
3 participants