-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing interaction between energy potentials and supply system operation #3543
Merged
reyery
merged 3 commits into
master
from
3542-optimisation-heat-rejection-components-are-not-operated-correctly
Apr 18, 2024
Merged
Fixing interaction between energy potentials and supply system operation #3543
reyery
merged 3 commits into
master
from
3542-optimisation-heat-rejection-components-are-not-operated-correctly
Apr 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously every time a category of components was operated the water-filling-principal method would check if the energy demand could be drawn from available energy potentials instead of supplying that energy using the components. This lead to false operating calculations since systems would try to draw energy that actually needed to be rejected instead. This newly introduced change should fix that.
Energy carriers were wrongly attributed to inputs and outputs of the CogenPlant component type, leading to a bug while matching energy flows for the supply system operation.
Fun! matthias when do you have time to check it 30 min online? I just want to avoid misinterpreting this cool input.Your late afternoon? My morning? (7 am CH)Best, jimenoOn 5 Apr 2024, at 06:35, Mathias Niffeler ***@***.***> wrote:When performing the 'cascading' activation of the components installed in the supply system, the previous code would erroneously look at the availability of the demand from renewable energy potentials and grids independently of the component category.
This has now been fixed. With the new code:
Main cooling/heating components (i.e. primary components) would check if their demand could be met by potentials or the grid prior to activation.
Supply components (i.e. secondary components) would check if their demand can be satisfied by the remaining renewable energy potentials and/or the grid.
Lastly, heat rejection components (i.e. tertiary components) would check if the heat they need to reject can be directly expulsed to the environment prior to their activation.
Additionally, a mistake was fixed for cogeneration plants, where the wrong energy carriers were attributed to their outputs.
You can view, comment on, or merge this pull request online at:
#3543
Commit Summary
b91d88b Update supply system operation
b20e24b fix energy carriers for CogenPlants
File Changes (2 files)
M
cea/optimization_new/component.py
(4)
M
cea/optimization_new/supplySystem.py
(14)
Patch Links:
https://github.com/architecture-building-systems/CityEnergyAnalyst/pull/3543.patch
https://github.com/architecture-building-systems/CityEnergyAnalyst/pull/3543.diff
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: ***@***.***>
|
Hi @jimenofonseca, I'm sorry I missed this message. Let's check it sometime next week. How about Monday at 9 a.m. CET? |
reyery
approved these changes
Apr 12, 2024
…s-are-not-operated-correctly
@MatNif the PR looks good to me. Do you have anything else to change? If not I would merge it. |
No, nothing else to add. You can go ahead and merge. |
reyery
deleted the
3542-optimisation-heat-rejection-components-are-not-operated-correctly
branch
April 18, 2024 08:52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing the 'cascading' activation of the components installed in the supply system, the previous code would erroneously look at the availability of the demand from renewable energy potentials and grids independently of the component category.
This has now been fixed. With the new code:
Additionally, a mistake was fixed for cogeneration plants, where the wrong energy carriers were attributed to their outputs.