Use constant for max achievable angle instead of magic number.

Author: aentinger

examples/Tools/Test_Motor_Angular_Control/Test_Motor_Angular_Control.ino

@@ -35,7 +35,7 @@ void test_motor(int const id)
   Serial.println("OK.");
   delay(1500);
 
-  for (float target_angle = 0.0f; target_angle < 315.0f; target_angle += 1.0f)
+  for (float target_angle = 0.0f; target_angle < SmartServoClass::MAX_ANGLE; target_angle += 1.0f)
   {
     Braccio.get(id).move().to(target_angle).in(200ms);
     delay(250);

src/lib/motors/SmartServo.h

@@ -74,14 +74,14 @@ class SmartServoClass
   inline int getErrors() const { return _errors; }
 
   static const int BROADCAST = 0xFE;
+  static float constexpr MAX_ANGLE = 315.0f;
 
 private:
 
-  static int   constexpr NUM_MOTORS = 6;
-  static int   constexpr MAX_TX_PAYLOAD_LEN = (5*NUM_MOTORS+4);
-  static int   constexpr MAX_RX_PAYLOAD_LEN = 10;
-  static int   constexpr MAX_POSITION = 4000;
-  static float constexpr MAX_ANGLE = 315.0f;
+  static int constexpr NUM_MOTORS = 6;
+  static int constexpr MAX_TX_PAYLOAD_LEN = (5*NUM_MOTORS+4);
+  static int constexpr MAX_RX_PAYLOAD_LEN = 10;
+  static int constexpr MAX_POSITION = 4000;
 
   static int constexpr MIN_MOTOR_ID = 1;
   static int constexpr MAX_MOTOR_ID = 6;