Add ripple to close button in WebActivity, fix tint color not being applied to the ProgressBar. Remove unnecessary null checks.

Author: mateuszdrzazga

OpenScienceJournal/whistlepunk_library/src/main/java/com/google/android/apps/forscience/whistlepunk/signin/WebActivity.java

@@ -87,30 +87,24 @@ protected void onCreate(Bundle savedInstanceState) {
     @Override
     protected void onDestroy() {
         super.onDestroy();
-        if (mWebView != null) {
-            mWebView.destroy();
-        }
+        mWebView.destroy();
     }
 
     @Override
     protected void onPause() {
         super.onPause();
-        if (mWebView != null) {
-            mWebView.onPause();
-        }
+        mWebView.onPause();
     }
 
     @Override
     protected void onResume() {
         super.onResume();
-        if (mWebView != null) {
-            mWebView.onResume();
-        }
+        mWebView.onResume();
     }
 
     @Override
     public void onBackPressed() {
-        if (mWebView != null && mWebView.canGoBack()) {
+        if (mWebView.canGoBack()) {
             mWebView.goBack();
         } else {
             super.onBackPressed();

OpenScienceJournal/whistlepunk_library/src/main/res/layout/activity_arduino_auth_web.xml

@@ -20,8 +20,10 @@
             android:layout_width="40dp"
             android:layout_height="40dp"
             android:layout_marginStart="18dp"
-            android:background="@null"
+            android:background="?selectableItemBackgroundBorderless"
+            android:clickable="true"
             android:contentDescription="@null"
+            android:focusable="true"
             android:scaleType="centerInside"
             android:src="@drawable/ic_arduino_auth_close"
             app:layout_constraintBottom_toBottomOf="parent"
@@ -65,9 +67,9 @@
             android:layout_width="0dp"
             android:layout_height="4dp"
             android:elevation="0dp"
-            android:foregroundTint="@color/arduino_carrot"
             android:indeterminate="false"
             android:max="100"
+            android:progressTint="@color/arduino_carrot"
             android:visibility="gone"
             app:layout_constraintBottom_toBottomOf="parent"
             app:layout_constraintEnd_toEndOf="parent"