Merge pull request #26 from arduino/sensor-info

Emilio Pavia · web-flow · commit 0585e6e5fde1 · 2020-10-06T10:08:02.000+02:00
Hide whatsGoingOnLabel if not needed
diff --git a/ScienceJournal/UI/LearnMoreViewController.swift b/ScienceJournal/UI/LearnMoreViewController.swift
@@ -102,6 +102,10 @@ class LearnMoreViewController: MaterialHeaderViewController {
     scrollView.addSubview(stackView)
     stackView.pinToEdgesOfView(scrollView)
     stackView.widthAnchor.constraint(equalTo: scrollView.widthAnchor).isActive = true
+
+    if sensor.learnMore == nil || sensor.learnMore!.isEmpty {
+      whatsGoingOnLabel.isHidden = true
+    }
   }
 
   override func accessibilityPerformEscape() -> Bool {
@@ -116,3 +120,9 @@ class LearnMoreViewController: MaterialHeaderViewController {
   }
 
 }
+
+extension Sensor.LearnMore {
+  var isEmpty: Bool {
+    firstParagraph.isEmpty && secondParagraph.isEmpty && imageName.isEmpty
+  }
+}

Original file line number	Diff line number	Diff line change
`@@ -102,6 +102,10 @@ class LearnMoreViewController: MaterialHeaderViewController {`
`102`	`102`	`scrollView.addSubview(stackView)`
`103`	`103`	`stackView.pinToEdgesOfView(scrollView)`
`104`	`104`	`stackView.widthAnchor.constraint(equalTo: scrollView.widthAnchor).isActive = true`
	`105`	`+`
	`106`	`+ if sensor.learnMore == nil \|\| sensor.learnMore!.isEmpty {`
	`107`	`+ whatsGoingOnLabel.isHidden = true`
	`108`	`+ }`
`105`	`109`	`}`
`106`	`110`
`107`	`111`	`override func accessibilityPerformEscape() -> Bool {`
`@@ -116,3 +120,9 @@ class LearnMoreViewController: MaterialHeaderViewController {`
`116`	`120`	`}`
`117`	`121`
`118`	`122`	`}`
	`123`	`+`
	`124`	`+extension Sensor.LearnMore {`
	`125`	`+ var isEmpty: Bool {`
	`126`	`+ firstParagraph.isEmpty && secondParagraph.isEmpty && imageName.isEmpty`
	`127`	`+ }`
	`128`	`+}`