Added support for all variants of Sanguino #1347
Merged
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW, this is actually a very simple pull request to generalize a few #ifdefs in the code from ATmega1284P or ATmega644P only to more ATmega644* and ATmega1284• variants. I'd personally like to see it merged, since I occasionally end up with ATmega1284's instead of ATmega1284P's (e.g. when building my cellphone). |
cmaglie
added a commit
that referenced
this pull request
May 3, 2013
Added support for all variants of Sanguino
oriregev
pushed a commit
to oriregev/Arduino
that referenced
this pull request
Dec 20, 2013
Added support for all variants of Sanguino
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have created a git repository with support for all variants of Sanguino:
Both 16MHz and 8MHz versions are available.
My repo can be found here: https://github.com/Lauszus/Sanguino.
I don't know how your opinion is regarding adding support for other MCU's, but I think these are rather popular and they are also available in a DIP package, so I think it would be nice if they where supported in the official core.