added support for '-' in filenames

[oni303]

This adds support for minuses in filenames.
It is a cleaned up version of #1772

[matthijskooijman]

Looks good to me!

[Lauszus]

Would it possible to do something similar for libraries directories as well? I have helped dozens of beginners who can't get some library working because they did not realize that it was not allowed to have any special characters.

[oni303]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Directories are also supported by this change, I tested it.
For libraries I am not sure, but in my opinion it should work.
The patch changes the general name checking.

On 01.01.2014 17:15, Kristian Sloth Lauszus wrote:

Would it possible to do something similar for libraries directories
as well? I have helped dozens of beginners who can't get some
library working because they did not realize that it was not
allowed to have any special characters.

— Reply to this email directly or view it on GitHub
#1773 (comment).

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Icedove - http://www.enigmail.net/

iQIcBAEBAgAGBQJSxHnfAAoJEPFuaghsrAvJ0a0P/3ZeZdNkvMap5uwCdEtwgYaw
dyGSml/DaG2KPUvfIJ1cBu1xandwQQTXSBM3fd2Nx2JFR/ZIzIwINOyTYgH9n1SW
wXj0EI/TjF7Q4Cr9rnhYU0j7UMeznly1FQSwxLF3aMZ/NseHKcwPpmwgnmd2/oeA
Euo3Vmzw9nrcx7sRz6uxSJJIKFKFgpsElWXEAdI0upnxENw/nHKllGPwOXL1iXpW
DMpBxImaGXRdE8wLVhKExAwVEnCWuC0tbqfb47+nEYbLXPZxJnDiE6UtmtxN7/rs
COBsg9i3wryB5RoE/cxYoOevdIptGE+3oQ57QT/2CI3U5/NsZVyOvXSKDrckKR1J
Xbwm71tf9oI/NiwkTwrZtT7qRKDt/AdKJ0u8usg5tz/xKku9tJoIZbtNPTZaVAtF
NjqdAcrXEahgIDfYMsNKVs1GxEInH1eVsfzy8+1Rlv8m5R/xL4Kf0dj1ikY/pEQG
IAOPNL3Rzf/JIrSQZVXqH8wNLucyXEixpX2RynsweeDSGvTGpjtMGi0+WE4+lL0S
0TD1DHUfWqH+Qf81gyv+ji3pLkLeE0lFhwqk+5PMAbxSoJQlSrVs4npfxAQHVxDh
jFUH5OtuDghsOncG1+BoERiL1rlvM/2qg6uZV6NJTfWQQpa2uhrUEfvoXjQJ4xCd
WEhooYD04flJASNdz2kd
=NywQ
-----END PGP SIGNATURE-----

[Lauszus]

Okay super. Could you add support for '.' in directories as well?

[oni303]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I am personally no friend of supporting dots in directories.
In Linux this will allow hidden ones also because these are started
with a dot.
So it will show ".git" and so on and may confuse beginners.
On 01.01.2014 23:01, Kristian Sloth Lauszus wrote:

Could you add support for '.' in directories as well?

— Reply to this email directly or view it on GitHub
#1773 (comment).

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Icedove - http://www.enigmail.net/

iQIcBAEBAgAGBQJSxJQaAAoJEPFuaghsrAvJwTgQAKMox2K3pMf36rtHyveBov1C
G6JkwffwRaZyA9yYuWY9rziOoWweUomO9A+xWL+0Gb/y06SF+Lxt1T4siGznR7Yv
DO3VHm3m+XtNbgRJfuWnpoXM7LbHBtlbADZcB6VxehQl+lcprPiOlS9sziswJ63z
6MdzvCZD9T5BDMFSsy49GoHDY7L2uLKdK6Pv9y8i47bQazMdbQDOhnXYlBpPk0oS
CfoctUUFcl+ldGUKvc4+Dv4WPKaWyL8cU5uVpQIo7bc2WAaaKN9+G6Ly9rRvb9mP
OOhIO7eczoRKHPj7IBB9ADdz6Q2F7Zy0h57kmsmOr/xewC62x7NSUntf27/ZcbKa
4zLExWa5tBELhKQ9UFdJkFBLGQ2gHXLlpQ4kMf0iFeumMk0mdqYQHjM82zDe8MSD
AAreLJVzz2IrG96gWH6FtjoCeZGUU5XKr4uKf5x85PWnEbKs8qJhUA4sHZBovYn6
Bht5hBoiM/c0cRPqXUoCkaoWxEm/tH5YWxHn0a/HmUBoRlX7NVn5vun5LPX7RkrL
KzP7fnjVMlCP5omhFb8x3XGhjNTg6QjAhNaJxJkBCw4M7n7WBk0fnFBNrJ72VBNm
IlAZ4VrG1bS0KUjp9vD/LSnL7Ol+NXEN0hBVApoL6pSWYv3v+jlAYVm6pk/oeu5A
W1VMV4pMBeQ4nui5Gs1C
=xBuF
-----END PGP SIGNATURE-----

[matthijskooijman]

I just tested this commit with a library with - in the (directory) name, works like a charm. Commit looks good to me as well, so please consider merging it for 1.5.6 :-)

[Lauszus]

@oni303 we could do is just allow it if it is not in the beginning of the name. The reason why I want this is because I am a contributer to the USB Host Shield library: https://github.com/felis/USB_Host_Shield_2.0 and I have spent so much time explaining beginngers how they should rename the library before they can use it.

[matthijskooijman]

Lauszus' suggestions seems reasonable. If we implement this, it should probably end up in a separate commit on top of the one already in this pullrequest, since they are separate changes with different complexity. @oni303, if you want to implement this, that would be great. You should be able to just add one more commit to the branch in your own repo and github will automatically add the commit here as well.

[oni303]

is there a reason not to allow '-' at the beginning?
I know it is a bit strange to name files like that but will it break anything?

[matthijskooijman]

I can imagine some commands might not like that (though usually that can be solved by using -- (e.g., cmd -foo -bar -- -file-with-dash.c or a full path). Dunno about other problems. though.

[oni303]

Hi,

I added support for '.' and for '-' and forbid both as the first character

[matthijskooijman]

Looks good to me. Perhaps you should rebase this branch and squash all commits together, since they're really just one logical change?

[oni303]

ok now it is a single commit on top of the current master

[oni303]

now it is also in the right coding style
and final from my point of view

[Lauszus]

Looks good to me. Thanks @oni303!

[matthijskooijman]

No more comments from my side either, thanks!

[cmaglie]

Thank you! Maybe this is something worth to include in 1.0.x too?

[matthijskooijman]

Seems good to me, that makes it easier to actually use - in filenames without requiring users to use 1.5.

[oni303]

I there is no disadvantage of including it into 1.0.x too.
So it would be nice to include it to 1.0.x. too.

[cmaglie]

Oh well, it was already in 1.0.x. Cool.
C