Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for file:// schema to set local additional URLs #1098

Merged
merged 3 commits into from Dec 3, 2020
Merged

Add support for file:// schema to set local additional URLs #1098

merged 3 commits into from Dec 3, 2020

Conversation

silvanocerza
Copy link
Contributor

@silvanocerza silvanocerza commented Dec 3, 2020 •
edited

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Changes an unreleased feature.

  • What is the current behavior?

User can set board_manager.additional_paths to set paths to local indexes.

  • What is the new behavior?

User must now set board_manager.additional_urls with the file:// schema to set paths to local indexes.

No.

  • Other information:

Solves #664.

See how to contribute

@silvanocerza silvanocerza added topic: documentation Related to documentation for the project component/CLI labels Dec 3, 2020
@silvanocerza silvanocerza self-assigned this Dec 3, 2020
@silvanocerza silvanocerza force-pushed the scerza/additional-paths-to-urls branch from c7b74fc to 7edf79e Compare December 3, 2020 13:57
ubidefeo
ubidefeo approved these changes Dec 3, 2020
View reviewed changes
Copy link

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested build and worked

@silvanocerza silvanocerza force-pushed the scerza/additional-paths-to-urls branch from a0f0326 to 73024f9 Compare December 3, 2020 16:30
@silvanocerza silvanocerza merged commit 4b3758b into master Dec 3, 2020
@silvanocerza silvanocerza deleted the scerza/additional-paths-to-urls branch December 3, 2020 17:20
@silvanocerza silvanocerza mentioned this pull request May 24, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaglie cmaglie cmaglie approved these changes

@ubidefeo ubidefeo ubidefeo approved these changes

@per1234 per1234 Awaiting requested review from per1234

@rsora rsora Awaiting requested review from rsora

Assignees

@silvanocerza silvanocerza

Labels
topic: documentation Related to documentation for the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@silvanocerza @cmaglie @ubidefeo