Enhance error messages if config paths are not valid #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PyPi is having issues so CI is failing since it can't install depencencies necessary for testing. I'll restart it as soon as the issue on PyPi is solved. |
per1234
reviewed
Jan 12, 2021
silvanocerza
force-pushed
the
scerza/enhance-error-message
branch
from
246411b
to
32dc14f
Compare
per1234
approved these changes
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)Enhances error messages.
If there are invalid paths for certain settings in the config file multiple errors are returned but are not clear enough, also certain commands still keep going forward.
Full invalid paths in the config file are now printed in full and only one error is shown, execution also stops for all commands if an error is returned.
No breaking change.
Solves #1114.
See how to contribute